Bug 205508

Summary: IsolatedObject support for multiple parameterized attributes.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andres Gonzalez
Reported 2019-12-20 10:39:42 PST
IsolatedObject support for multiple parameterized attributes.
Attachments
Patch (36.01 KB, patch)
2019-12-20 10:51 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2019-12-20 10:51:51 PST
Created attachment 386224 [details] Patch
chris fleizach
Comment 2 2019-12-20 11:01:15 PST
Comment on attachment 386224 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386224&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.cpp:1409 > + return associatedAXObject()->documentFrameView(); do we want main thread asserts in these?
Andres Gonzalez
Comment 3 2019-12-20 11:16:19 PST
(In reply to chris fleizach from comment #2) > Comment on attachment 386224 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=386224&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.cpp:1409 > > + return associatedAXObject()->documentFrameView(); > > do we want main thread asserts in these? They already do because associatedAXObject calls axObjectCache() that asserts isMainThread.
WebKit Commit Bot
Comment 4 2019-12-20 12:33:27 PST
Comment on attachment 386224 [details] Patch Clearing flags on attachment: 386224 Committed r253835: <https://trac.webkit.org/changeset/253835>
WebKit Commit Bot
Comment 5 2019-12-20 12:33:28 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-12-20 12:34:19 PST
<rdar://problem/58122420>
Note You need to log in before you can comment on or make changes to this bug.