Bug 205497

Summary: [GTK] InputMethod API unit tests don't work under X11
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, ews-watchlist, gustavo, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch zan: review+

Description Carlos Garcia Campos 2019-12-20 05:29:21 PST 
The input method filter requires the web view to be focused to be enabled. Under X11 we only get the focus if the parent window is a toplevel and tests were using a popup. Using a toplevelo is enough for X11 with a window manager, but not for tests running under xvfb because there isn't a window manager. We need to assume the web view is always focused when running the tests under xvfb
Comment 1 Carlos Garcia Campos 2019-12-20 05:32:54 PST 
Created attachment 386209 [details]
Patch
Comment 2 EWS Watchlist 2019-12-20 05:33:45 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2019-12-20 05:56:01 PST 
Created attachment 386210 [details]
Patch
Comment 4 Carlos Garcia Campos 2019-12-23 02:06:37 PST 
Committed r253882: <https://trac.webkit.org/changeset/253882>