Bug 205491

Summary: Compile libwebrtc without hardware acceleration for iOS simulator
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, commit-queue, eric.carlson, ews-watchlist, krollin, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=205353
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2019-12-20 00:50:59 PST
Compile libwebrtc without hardware acceleration for iOS simulator
Attachments
Patch (701.11 KB, patch)
2019-12-20 01:11 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-12-20 01:11:44 PST
Created attachment 386187 [details] Patch
youenn fablet
Comment 2 2019-12-20 04:47:50 PST
This patch does not remove yasm as a dependency to libvpx in iOS and iOS simulator. I think we should do that as a follow-up.
Keith Rollin
Comment 3 2019-12-20 11:25:41 PST
You're adding a number of files here that are marked as "// This file is generated. Do not edit." Should these files be checked in? Or should we just include their generation as part of the build process? Personally, I prefer the latter. But if the former, are there instructions how to (re-)generate them later if needed?
Keith Rollin
Comment 4 2019-12-20 11:28:01 PST
Also, these new files are presumably for the iOS-simulator build. But the files are stored in a mac/x86 directory. Wouldn't we already have such files for the macOS build? Why are there new files?
Alex Christensen
Comment 5 2019-12-20 11:29:46 PST
The macOS build uses yasm to get optimized x86_64 vpx code. That's not needed in the iOS simulator. We could put them in iOS/x86 instead of Mac/x86
Keith Rollin
Comment 6 2019-12-20 11:30:18 PST
Sorry. I got a little confused there. I was thinking that the C/C++ files should already exist for *iOS* (not macOS), right? Can't those be used for the iOS Simulator build?
Keith Rollin
Comment 7 2019-12-20 15:04:46 PST
With this change, you can also get rid of the DYLD_ROOT_PATH hack in the custom build rule that invokes yasm.
youenn fablet
Comment 8 2019-12-22 05:55:59 PST
(In reply to Keith Rollin from comment #6) > Sorry. I got a little confused there. I was thinking that the C/C++ files > should already exist for *iOS* (not macOS), right? Can't those be used for > the iOS Simulator build? The files for iOS expect arm and iOS sim is x86_64 based which makes it somehow closer to macOS for the build. I guess we could use iOS files and tweak them for iOS sim as well.
youenn fablet
Comment 9 2019-12-22 05:56:25 PST
(In reply to Keith Rollin from comment #7) > With this change, you can also get rid of the DYLD_ROOT_PATH hack in the > custom build rule that invokes yasm. Will do in a follow-up, with the removal of yasm as a dependency to libvpx for iOS/iOS sim
WebKit Commit Bot
Comment 10 2019-12-22 06:42:57 PST
Comment on attachment 386187 [details] Patch Clearing flags on attachment: 386187 Committed r253872: <https://trac.webkit.org/changeset/253872>
WebKit Commit Bot
Comment 11 2019-12-22 06:42:59 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2019-12-22 06:43:15 PST
<rdar://problem/58142578>
youenn fablet
Comment 13 2019-12-23 05:26:59 PST
(In reply to youenn fablet from comment #9) > (In reply to Keith Rollin from comment #7) > > With this change, you can also get rid of the DYLD_ROOT_PATH hack in the > > custom build rule that invokes yasm. > > Will do in a follow-up, with the removal of yasm as a dependency to libvpx > for iOS/iOS sim https://bugs.webkit.org/show_bug.cgi?id=205556
Note You need to log in before you can comment on or make changes to this bug.