Bug 205475

Summary: Web Inspector: convert some InspectorFrontendHost methods to getters
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Proposed fix
none
Patch
none
Patch none

Blaze Burg
Reported 2019-12-19 14:36:22 PST
.
Attachments
Patch (13.13 KB, patch)
2019-12-19 14:38 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Proposed fix (22.35 KB, patch)
2019-12-19 14:59 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (24.14 KB, patch)
2019-12-19 16:04 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch (26.59 KB, patch)
2019-12-20 11:07 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2019-12-19 14:38:21 PST
Created attachment 386143 [details] Patch
Blaze Burg
Comment 2 2019-12-19 14:59:43 PST
Created attachment 386150 [details] Proposed fix
Blaze Burg
Comment 3 2019-12-19 16:04:04 PST
Created attachment 386161 [details] Patch
Devin Rousso
Comment 4 2019-12-19 16:09:24 PST
Comment on attachment 386161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386161&action=review r=me once EWS is happy :) > Source/WebCore/inspector/InspectorFrontendHost.h:85 > String port(); Shouldn't this also be `const`? > Source/WebCore/inspector/InspectorFrontendHost.h:89 > + String platform() const; NIT: why not put this next to `port`?
Blaze Burg
Comment 5 2019-12-20 11:07:24 PST
Created attachment 386226 [details] Patch
Blaze Burg
Comment 6 2019-12-20 12:42:58 PST
Committed r253837: <https://trac.webkit.org/changeset/253837>
Radar WebKit Bug Importer
Comment 7 2019-12-20 12:43:18 PST
<rdar://problem/58122650>
Note You need to log in before you can comment on or make changes to this bug.