Bug 205445

Summary:

REGRESSION(r253683): [GTK][WPE] Lots of offscreen-canvas WPT tests failing

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

WebKitGTK

Assignee:

Chris Lord <clord>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, cdumez, cgarcia, clopez, clord, commit-queue, dino, fujii.hironori, rego

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

205850

Bug Blocks:

205342

Attachments:

Description	Flags
WIP Patch	none
Update OffscreenCanvas tests and related files	none
Patch	none
Patch	none
Patch	none

Carlos Alberto Lopez Perez

Reported 2019-12-19 04:34:55 PST

r253683 broken all offscreen-canvas tests, which used the canvas-related files in LayoutTests/imported/w3c/web-platform-tests/common/ that were deleted by this patch.

Attachments
WIP Patch (2.15 MB, patch) 2019-12-19 09:43 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Update OffscreenCanvas tests and related files (2.47 MB, patch) 2019-12-20 03:29 PST, Chris Lord	no flags	Details Formatted Diff Diff
Patch (2.48 MB, patch) 2020-01-10 03:07 PST, Chris Lord	no flags	Details Formatted Diff Diff
Patch (2.46 MB, patch) 2020-01-10 09:00 PST, Chris Lord	no flags	Details Formatted Diff Diff
Patch (2.46 MB, patch) 2020-01-13 01:41 PST, Chris Lord	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Carlos Alberto Lopez Perez

Comment 1 2019-12-19 04:55:54 PST

Skipped the tests in r253747 Please revert the changes from r253747 when fixing this issue so those tests run back

Chris Lord

Comment 2 2019-12-19 08:00:21 PST

So after updating, there are some legitimate failures, I think because the tests are malformed... I'll see about fixing them in wpt -_-

Chris Dumez

Comment 3 2019-12-19 09:43:38 PST

Created attachment 386113 [details] WIP Patch I will let somebody else take over (update expected results) given that I am unable to run those tests.

Chris Lord

Comment 4 2019-12-20 03:29:11 PST

Created attachment 386195 [details] Update OffscreenCanvas tests and related files WIP patch - Note, the fixed tests also expose a debug-only assert with ImageBitmap creation, so that needs to be fixed before this can be applied.

Chris Lord

Comment 5 2020-01-10 03:07:57 PST

Created attachment 387322 [details] Patch

Chris Lord

Comment 6 2020-01-10 04:37:22 PST

Comment on attachment 387322 [details] Patch Removing flags while I investigate failures.

Chris Lord

Comment 7 2020-01-10 09:00:39 PST

Created attachment 387341 [details] Patch

Chris Lord

Comment 8 2020-01-13 01:41:31 PST

Created attachment 387507 [details] Patch

Chris Lord

Comment 9 2020-01-13 03:41:29 PST

Comment on attachment 387507 [details] Patch Looking good now. One new test passing because of the resource update I believe.

WebKit Commit Bot

Comment 10 2020-01-13 16:04:45 PST

The commit-queue encountered the following flaky tests while processing attachment 387507 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 11 2020-01-13 16:10:55 PST

Comment on attachment 387507 [details] Patch Clearing flags on attachment: 387507 Committed r254467: <https://trac.webkit.org/changeset/254467>

WebKit Commit Bot

Comment 12 2020-01-13 16:10:57 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.