Bug 205429

Summary:

macCatalyst: Cursor should update when the platform deems it necessary

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+

Description Tim Horton 2019-12-18 17:54:37 PST

macCatalyst: Cursor should update when the platform deems it necessary

Comment 1 Tim Horton 2019-12-18 17:55:13 PST

Created attachment 386044 [details]
Patch

Comment 2 Tim Horton 2019-12-18 17:55:15 PST

<rdar://problem/57983076>

Comment 3 Wenson Hsieh 2019-12-18 17:57:13 PST

Comment on attachment 386044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386044&action=review

> Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:87
> +    float caretHeight;

Nit - maybe give this an initial value?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2766
> +    if (Frame* frame = hitTestResult.innerNodeFrame()) {
> +        if (FrameView *frameView = frame->view()) {

Nit - auto*?

Comment 4 Tim Horton 2019-12-18 18:21:53 PST

https://trac.webkit.org/changeset/253731/webkit