Bug 205423

Summary: Deny mach lookup access to "com.apple.TextInput" in the WebContent process
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, ggaren, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Description Brent Fulgham 2019-12-18 15:37:26 PST 
Testing, telemetry, and code review indicate that we do not need access to 'com.apple.TextInput' in the WebContent process.

We should remove this permission.
Comment 1 Brent Fulgham 2019-12-18 15:37:47 PST 
<rdar://problem/56990842>
Comment 2 Brent Fulgham 2019-12-18 15:42:27 PST 
Created attachment 386023 [details]
Patch
Comment 3 Brent Fulgham 2019-12-18 17:21:16 PST 
Created attachment 386039 [details]
Patch
Comment 4 Per Arne Vollan 2019-12-19 06:56:04 PST 
Comment on attachment 386039 [details]
Patch

Looks good! R=me.
Comment 5 WebKit Commit Bot 2019-12-19 10:04:53 PST 
Comment on attachment 386039 [details]
Patch

Rejecting attachment 386039 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 386039, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/13293442
Comment 6 Brent Fulgham 2019-12-19 10:58:29 PST 
Created attachment 386122 [details]
Patch for landing
Comment 7 Brent Fulgham 2019-12-19 11:01:22 PST 
Comment on attachment 386122 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=386122&action=review

> Source/WebKit/ChangeLog:7
> +        <rdar://problem/56990842>

This isn't right.
Comment 8 Brent Fulgham 2019-12-19 11:01:53 PST 
Created attachment 386123 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2019-12-19 11:48:41 PST 
Comment on attachment 386123 [details]
Patch for landing

Clearing flags on attachment: 386123

Committed r253777: <https://trac.webkit.org/changeset/253777>
Comment 10 WebKit Commit Bot 2019-12-19 11:48:42 PST 
All reviewed patches have been landed.  Closing bug.