Bug 205423 - Deny mach lookup access to "com.apple.TextInput" in the WebContent process
Summary: Deny mach lookup access to "com.apple.TextInput" in the WebContent process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-18 15:37 PST by Brent Fulgham
Modified: 2019-12-19 11:48 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2019-12-18 15:42 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (3.91 KB, patch)
2019-12-18 17:21 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (4.20 KB, patch)
2019-12-19 10:58 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (4.20 KB, patch)
2019-12-19 11:01 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-12-18 15:37:26 PST 
Testing, telemetry, and code review indicate that we do not need access to 'com.apple.TextInput' in the WebContent process.

We should remove this permission.
Comment 1 Brent Fulgham 2019-12-18 15:37:47 PST 
<rdar://problem/56990842>
Comment 2 Brent Fulgham 2019-12-18 15:42:27 PST 
Created attachment 386023 [details]
Patch
Comment 3 Brent Fulgham 2019-12-18 17:21:16 PST 
Created attachment 386039 [details]
Patch
Comment 4 Per Arne Vollan 2019-12-19 06:56:04 PST 
Comment on attachment 386039 [details]
Patch

Looks good! R=me.
Comment 5 WebKit Commit Bot 2019-12-19 10:04:53 PST 
Comment on attachment 386039 [details]
Patch

Rejecting attachment 386039 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 386039, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/13293442
Comment 6 Brent Fulgham 2019-12-19 10:58:29 PST 
Created attachment 386122 [details]
Patch for landing
Comment 7 Brent Fulgham 2019-12-19 11:01:22 PST 
Comment on attachment 386122 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=386122&action=review

> Source/WebKit/ChangeLog:7
> +        <rdar://problem/56990842>

This isn't right.
Comment 8 Brent Fulgham 2019-12-19 11:01:53 PST 
Created attachment 386123 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2019-12-19 11:48:41 PST 
Comment on attachment 386123 [details]
Patch for landing

Clearing flags on attachment: 386123

Committed r253777: <https://trac.webkit.org/changeset/253777>
Comment 10 WebKit Commit Bot 2019-12-19 11:48:42 PST 
All reviewed patches have been landed.  Closing bug.