Bug 205411

Summary: WebContent process does not need access to 'com.apple.system.logger'
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, ggaren, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214090
Attachments:
Description Flags
Patch
none
Patch
none
Patch pvollan: review+, commit-queue: commit-queue-

Description Brent Fulgham 2019-12-18 14:06:44 PST 
The WebContent process does not need access to the 'com.apple.system.logger' mach service.

We should remove it.
Comment 1 Brent Fulgham 2019-12-18 14:07:02 PST 
<rdar://problem/56966080>
Comment 2 Brent Fulgham 2019-12-18 14:10:57 PST 
Created attachment 386004 [details]
Patch
Comment 3 Brent Fulgham 2019-12-18 14:31:50 PST 
Created attachment 386006 [details]
Patch
Comment 4 Alexey Proskuryakov 2019-12-18 14:40:31 PST 
Are changes that remove generic services like this one being explicitly tested on all supported OS versions?
Comment 5 Brent Fulgham 2019-12-18 14:42:21 PST 
(In reply to Alexey Proskuryakov from comment #4)
> Are changes that remove generic services like this one being explicitly
> tested on all supported OS versions?

Yes.
Comment 6 Brent Fulgham 2019-12-18 16:30:33 PST 
Created attachment 386030 [details]
Patch
Comment 7 Per Arne Vollan 2019-12-19 07:04:39 PST 
Comment on attachment 386030 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386030&action=review

Great! R=me.

> LayoutTests/platform/mac-wk2/TestExpectations:934
> +wbekit.org/b/205365 [ Mojave+ Debug ] fast/mediastream/captureStream/canvas2d-heavy-drawing.html [ Pass Failure ]

This change seems to cause a style error.
Comment 8 Per Arne Vollan 2019-12-19 07:12:55 PST 
I believe the iOS test failure is unrelated, since this patch only contains sandbox changes, which does not apply to the simulator.
Comment 9 Brent Fulgham 2019-12-19 09:03:48 PST 
Comment on attachment 386030 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386030&action=review

>> LayoutTests/platform/mac-wk2/TestExpectations:934
>> +wbekit.org/b/205365 [ Mojave+ Debug ] fast/mediastream/captureStream/canvas2d-heavy-drawing.html [ Pass Failure ]
> 
> This change seems to cause a style error.

The style error was existing. Touching the file causes the checker to complain.
Comment 10 WebKit Commit Bot 2019-12-19 10:04:10 PST 
Comment on attachment 386030 [details]
Patch

Rejecting attachment 386030 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 386030, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=386030&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=205411&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 386030 from bug 205411.
Fetching: https://bugs.webkit.org/attachment.cgi?id=386030
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/TestExpectations', u'LayoutTests/platform/mac-wk2/TestExpectations']" exit_code: 1

ERROR: LayoutTests/platform/mac-wk2/TestExpectations:929:  Unrecognized expectation "Mojave+"  [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:929:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:929:  Unrecognized expectation "Mojave+"  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:929:  Unrecognized expectation "Debug"  [test/expectations] [5]
Total errors found: 4 in 2 files

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/TestExpectations', u'LayoutTests/platform/mac-wk2/TestExpectations']" exit_code: 1

ERROR: LayoutTests/platform/mac-wk2/TestExpectations:929:  Unrecognized expectation "Mojave+"  [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:929:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:929:  Unrecognized expectation "Mojave+"  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:929:  Unrecognized expectation "Debug"  [test/expectations] [5]
Total errors found: 4 in 2 files

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/TestExpectations', u'LayoutTests/platform/mac-wk2/TestExpectations']" exit_code: 1
Updating OpenSource
From https://git.webkit.org/git/WebKit
   5ef0e891730..f35c258e3b2  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 253759 = 5ef0e89173030c7e6528177c6c12ea6c215bbd02
r253760 = f08976b1198a08e70162221ded35e4f710599a3d
r253761 = f35c258e3b28dc5f86363f059aa53848c47e31e4
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:929:  Unrecognized expectation "Mojave+"  [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:929:  Unrecognized expectation "Debug"  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:929:  Unrecognized expectation "Mojave+"  [test/expectations] [5]
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:929:  Unrecognized expectation "Debug"  [test/expectations] [5]
Total errors found: 4 in 2 files

Full output: https://webkit-queues.webkit.org/results/13293433
Comment 11 Brent Fulgham 2019-12-19 12:00:31 PST 
Committed r253778: <https://trac.webkit.org/changeset/253778>