The WebContent process does not need access to the 'com.apple.system.logger' mach service. We should remove it.
<rdar://problem/56966080>
Created attachment 386004 [details] Patch
Created attachment 386006 [details] Patch
Are changes that remove generic services like this one being explicitly tested on all supported OS versions?
(In reply to Alexey Proskuryakov from comment #4) > Are changes that remove generic services like this one being explicitly > tested on all supported OS versions? Yes.
Created attachment 386030 [details] Patch
Comment on attachment 386030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386030&action=review Great! R=me. > LayoutTests/platform/mac-wk2/TestExpectations:934 > +wbekit.org/b/205365 [ Mojave+ Debug ] fast/mediastream/captureStream/canvas2d-heavy-drawing.html [ Pass Failure ] This change seems to cause a style error.
I believe the iOS test failure is unrelated, since this patch only contains sandbox changes, which does not apply to the simulator.
Comment on attachment 386030 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386030&action=review >> LayoutTests/platform/mac-wk2/TestExpectations:934 >> +wbekit.org/b/205365 [ Mojave+ Debug ] fast/mediastream/captureStream/canvas2d-heavy-drawing.html [ Pass Failure ] > > This change seems to cause a style error. The style error was existing. Touching the file causes the checker to complain.
Comment on attachment 386030 [details] Patch Rejecting attachment 386030 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 386030, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=386030&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=205411&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 386030 from bug 205411. Fetching: https://bugs.webkit.org/attachment.cgi?id=386030 Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/TestExpectations', u'LayoutTests/platform/mac-wk2/TestExpectations']" exit_code: 1 ERROR: LayoutTests/platform/mac-wk2/TestExpectations:929: Unrecognized expectation "Mojave+" [test/expectations] [5] ERROR: LayoutTests/platform/mac-wk2/TestExpectations:929: Unrecognized expectation "Debug" [test/expectations] [5] ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:929: Unrecognized expectation "Mojave+" [test/expectations] [5] ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:929: Unrecognized expectation "Debug" [test/expectations] [5] Total errors found: 4 in 2 files Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/TestExpectations', u'LayoutTests/platform/mac-wk2/TestExpectations']" exit_code: 1 ERROR: LayoutTests/platform/mac-wk2/TestExpectations:929: Unrecognized expectation "Mojave+" [test/expectations] [5] ERROR: LayoutTests/platform/mac-wk2/TestExpectations:929: Unrecognized expectation "Debug" [test/expectations] [5] ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:929: Unrecognized expectation "Mojave+" [test/expectations] [5] ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:929: Unrecognized expectation "Debug" [test/expectations] [5] Total errors found: 4 in 2 files Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/TestExpectations', u'LayoutTests/platform/mac-wk2/TestExpectations']" exit_code: 1 Updating OpenSource From https://git.webkit.org/git/WebKit 5ef0e891730..f35c258e3b2 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 253759 = 5ef0e89173030c7e6528177c6c12ea6c215bbd02 r253760 = f08976b1198a08e70162221ded35e4f710599a3d r253761 = f35c258e3b28dc5f86363f059aa53848c47e31e4 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. ERROR: LayoutTests/platform/mac-wk2/TestExpectations:929: Unrecognized expectation "Mojave+" [test/expectations] [5] ERROR: LayoutTests/platform/mac-wk2/TestExpectations:929: Unrecognized expectation "Debug" [test/expectations] [5] ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:929: Unrecognized expectation "Mojave+" [test/expectations] [5] ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:929: Unrecognized expectation "Debug" [test/expectations] [5] Total errors found: 4 in 2 files Full output: https://webkit-queues.webkit.org/results/13293433
Committed r253778: <https://trac.webkit.org/changeset/253778>