Bug 205359

Summary: Port service worker code to the HTML5 event loop
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, rniwa, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/web-platform-tests/wpt/pull/20655
Bug Depends on: 205397    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2019-12-17 14:08:04 PST
Port service worker code to the HTML5 event loop. We're currently mixing using the HTML5 event loop and Document::postTask(), which is causing test flakiness.
Attachments
Patch (36.95 KB, patch)
2019-12-17 15:14 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-12-17 15:14:07 PST
Created attachment 385922 [details] Patch
Chris Dumez
Comment 2 2019-12-17 18:35:02 PST
Comment on attachment 385922 [details] Patch Clearing flags on attachment: 385922 Committed r253667: <https://trac.webkit.org/changeset/253667>
Chris Dumez
Comment 3 2019-12-17 18:35:04 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-12-17 18:36:25 PST
<rdar://problem/58029357>
Truitt Savell
Comment 5 2019-12-18 08:25:39 PST
It looks like the changes in https://trac.webkit.org/changeset/253667/webkit caused 32 test crashes, tracking in https://bugs.webkit.org/show_bug.cgi?id=205397
Chris Dumez
Comment 6 2019-12-18 08:38:46 PST
(In reply to Truitt Savell from comment #5) > It looks like the changes in https://trac.webkit.org/changeset/253667/webkit > caused 32 test crashes, tracking in > https://bugs.webkit.org/show_bug.cgi?id=205397 I am working on it, thanks.
Chris Dumez
Comment 7 2019-12-18 08:46:42 PST
(In reply to Chris Dumez from comment #6) > (In reply to Truitt Savell from comment #5) > > It looks like the changes in https://trac.webkit.org/changeset/253667/webkit > > caused 32 test crashes, tracking in > > https://bugs.webkit.org/show_bug.cgi?id=205397 > > I am working on it, thanks. Follow-up landed in <https://trac.webkit.org/changeset/253688> to address the debug assertions.
Note You need to log in before you can comment on or make changes to this bug.