Bug 20535

Summary: LinearTimingFunction should have control points 0,0,1,1 not 0,0,0,0
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch, fixed tests, changelog. eric: review+

Simon Fraser (smfr)
Reported 2008-08-26 17:47:32 PDT
getComputedStyle() for transition-timing-function or animation-timing-function returns a cubic-bezier() always. This is OK, but for a linear timing function, it returns cubic-bezier(0,0,0,0). That should be cubic-bezier(0,0,1,1)
Attachments
Patch, fixed tests, changelog. (5.41 KB, patch)
2008-08-26 18:05 PDT, Simon Fraser (smfr) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2008-08-26 18:05:17 PDT
Created attachment 23013 [details] Patch, fixed tests, changelog.
Eric Seidel (no email)
Comment 2 2008-08-27 00:10:49 PDT
Comment on attachment 23013 [details] Patch, fixed tests, changelog. Why change CSSStyleSelector if you've changed the default constructor too? Otherwise looks fine.
Simon Fraser (smfr)
Comment 3 2008-08-27 08:27:24 PDT
I changed CSSStyleSelector because I wanted to make it obvious when creating the linear timing function that the correct control points are being passed.
Darin Adler
Comment 4 2008-08-27 09:52:03 PDT
Comment on attachment 23013 [details] Patch, fixed tests, changelog. ".0" is strange syntax for a 0 of type double. We normally use "0.0".
Simon Fraser (smfr)
Comment 5 2008-08-27 10:07:53 PDT
I'll fix before committing.
Simon Fraser (smfr)
Comment 6 2008-08-27 11:20:12 PDT
Committed r35943 M WebCore/rendering/style/RenderStyle.h M WebCore/ChangeLog M WebCore/css/CSSStyleSelector.cpp M LayoutTests/ChangeLog M LayoutTests/transitions/inherit-other-props-expected.txt M LayoutTests/transitions/inherit-other-props.html r35943 = e74d671ade9a443887ec1e832811b06adcf182e8 (trunk)
Note You need to log in before you can comment on or make changes to this bug.