Summary: | LinearTimingFunction should have control points 0,0,1,1 not 0,0,0,0 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | CSS | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dino | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2008-08-26 17:47:32 PDT
Created attachment 23013 [details]
Patch, fixed tests, changelog.
Comment on attachment 23013 [details]
Patch, fixed tests, changelog.
Why change CSSStyleSelector if you've changed the default constructor too?
Otherwise looks fine.
I changed CSSStyleSelector because I wanted to make it obvious when creating the linear timing function that the correct control points are being passed. Comment on attachment 23013 [details]
Patch, fixed tests, changelog.
".0" is strange syntax for a 0 of type double. We normally use "0.0".
I'll fix before committing. Committed r35943 M WebCore/rendering/style/RenderStyle.h M WebCore/ChangeLog M WebCore/css/CSSStyleSelector.cpp M LayoutTests/ChangeLog M LayoutTests/transitions/inherit-other-props-expected.txt M LayoutTests/transitions/inherit-other-props.html r35943 = e74d671ade9a443887ec1e832811b06adcf182e8 (trunk) |