Summary: | WebKitTestRunner should report GPU process crashes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | Tools / Tests | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, eric.carlson, sabouhallawa, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2019-12-17 06:57:30 PST
Created attachment 385884 [details]
Patch
Created attachment 385885 [details]
Patch
Comment on attachment 385885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385885&action=review > Source/WebKit/UIProcess/API/C/WKContext.h:108 > + WKContextChildProcessDidCrashCallback gpuProcessDidCrash; > } WKContextClientV3; Don't you need to bump the struct version? Otherwise folks using V3 will be missing one zero in their initializers :P (In reply to Tim Horton from comment #3) > Comment on attachment 385885 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385885&action=review > > > Source/WebKit/UIProcess/API/C/WKContext.h:108 > > + WKContextChildProcessDidCrashCallback gpuProcessDidCrash; > > } WKContextClientV3; > > Don't you need to bump the struct version? Otherwise folks using V3 will be > missing one zero in their initializers :P That should be fine, I bumped the version yesterday to v3 to report service worker process crashes. Comment on attachment 385885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385885&action=review >>> Source/WebKit/UIProcess/API/C/WKContext.h:108 >>> } WKContextClientV3; >> >> Don't you need to bump the struct version? Otherwise folks using V3 will be missing one zero in their initializers :P > > That should be fine, I bumped the version yesterday to v3 to report service worker process crashes. OH! Nice. Maybe throw a space before the "2" then? Comment on attachment 385885 [details] Patch Clearing flags on attachment: 385885 Committed r253639: <https://trac.webkit.org/changeset/253639> All reviewed patches have been landed. Closing bug. |