Summary: | [GTK][WPE] IndexedDB directory set in WebsiteDataManager is ignored | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, berto, bugs-noreply, cdumez, ews-watchlist, gustavo, youennf | ||||
Priority: | P2 | Keywords: | Gtk, Regression | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2019-12-17 01:50:24 PST
Created attachment 385866 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Could a WebKit2 owner check the cross-platform change, please? Youenn? Comment on attachment 385866 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385866&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:540 > parameters.defaultDataStoreParameters.indexedDatabaseDirectory = WebKit::WebsiteDataStore::defaultDataStore()->parameters().indexedDatabaseDirectory; LGTM. There is some pre-existing inconsistencies in this method with withWebsiteDataStore . Some other parameters like parameters.defaultDataStoreParameters.networkSessionParameters.networkCacheDirectory also check for withWebsiteDataStore. (In reply to youenn fablet from comment #4) > Comment on attachment 385866 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385866&action=review > > > Source/WebKit/UIProcess/WebProcessPool.cpp:540 > > parameters.defaultDataStoreParameters.indexedDatabaseDirectory = WebKit::WebsiteDataStore::defaultDataStore()->parameters().indexedDatabaseDirectory; > > LGTM. Thanks! > There is some pre-existing inconsistencies in this method with > withWebsiteDataStore . > Some other parameters like > parameters.defaultDataStoreParameters.networkSessionParameters. > networkCacheDirectory also check for withWebsiteDataStore. Yes, I noticed it too, but I wasn't sure what the expected behavior was in the end. Committed r253626: <https://trac.webkit.org/changeset/253626> |