Bug 205328

Summary: Update session category in MockAudioSharedUnit as done in CoreAudioSharedUnit
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 205056    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2019-12-17 00:49:38 PST
Update session category in MockAudioSharedUnit as done in CoreAudioSharedUnit
Attachments
Patch (5.14 KB, patch)
2019-12-17 01:00 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.15 KB, patch)
2019-12-17 06:40 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-12-17 01:00:42 PST
Created attachment 385865 [details] Patch
Eric Carlson
Comment 2 2019-12-17 06:32:38 PST
Comment on attachment 385865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385865&action=review > Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:93 > +bool BaseAudioSharedUnit::startUnit() This should return OSStatus since the value is returned by prepareForNewCapture in the event of a failure.
youenn fablet
Comment 3 2019-12-17 06:40:09 PST
Created attachment 385883 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-12-17 07:27:39 PST
Comment on attachment 385883 [details] Patch for landing Clearing flags on attachment: 385883 Committed r253628: <https://trac.webkit.org/changeset/253628>
WebKit Commit Bot
Comment 5 2019-12-17 07:27:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-12-17 07:28:19 PST
<rdar://problem/58005595>
Note You need to log in before you can comment on or make changes to this bug.