Bug 205312

Summary: IndexedDB: remove timer for pending operations in IDBTransaction
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, commit-queue, ews-watchlist, jsbell, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Sihui Liu
Reported 2019-12-16 16:29:39 PST
...
Attachments
Patch (12.88 KB, patch)
2019-12-16 16:43 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (12.09 KB, patch)
2019-12-16 16:47 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.94 KB, patch)
2019-12-19 17:20 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2019-12-16 16:43:20 PST
Created attachment 385829 [details] Patch
Sihui Liu
Comment 2 2019-12-16 16:47:48 PST
Created attachment 385830 [details] Patch
Brady Eidson
Comment 3 2019-12-19 10:10:50 PST
Comment on attachment 385830 [details] Patch If no regressions then... yay. Wish we could have a test that tries to make the web process unresponsive to verify this doesn't regress.
Sihui Liu
Comment 4 2019-12-19 17:17:13 PST
(In reply to Brady Eidson from comment #3) > Comment on attachment 385830 [details] > Patch > > If no regressions then... yay. > > Wish we could have a test that tries to make the web process unresponsive to > verify this doesn't regress. We have some stress tests in PerformanceTests/IndexedDB/stress. This change will make PerformanceTests/IndexedDB/stress/large-number-of-inserts-responsiveness.html a bit slower than before (10ms -> ~50ms) as IDB operations now can happen earlier now but so far no proof of web process being unresponsive.
Sihui Liu
Comment 5 2019-12-19 17:20:11 PST
Created attachment 386166 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-12-19 18:05:00 PST
Comment on attachment 386166 [details] Patch for landing Clearing flags on attachment: 386166 Committed r253807: <https://trac.webkit.org/changeset/253807>
WebKit Commit Bot
Comment 7 2019-12-19 18:05:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.