Bug 205288 – Add run-time flag for in-app browser privacy

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Kate Cheney]

We should add a flag for the in-app browser privacy feature

[Kate Cheney]

<rdar://problem/57569206>

[Kate Cheney]

Created attachment 385905 [details]
Patch

[John Wilander]

Comment on attachment 385905 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385905&action=review

r+ with comments.

I see you've put your setting next to Ad Click Attribution. Since they aren't really related, you don't have to. Please look at the change logs for these files to see where people add new settings unrelated to anything existing, and add yours accordingly. I assume it's append-style.

> Source/WebCore/page/RuntimeEnabledFeatures.h:156
> +    bool inAppBrowserPrivacyEnabled() const { return m_inAppBrowserPrivacyEnabled; }

I know we're not perfect in this regard for these kind of settings, but we should try to use the "is" prefix for getters of booleans.

> Source/WebKit/Shared/WebPreferences.yaml:1536
> +    humanReadableName: "In App Browser Privacy"

Needs a dash in "In-App."

> Source/WebKit/Shared/WebPreferences.yaml:1537
> +    humanReadableDescription: "Enable In App Browser Privacy"

Ditto.

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:3526
> +- (BOOL)inAppBrowserPrivacyEnabled

Similar for an "is" prefix.

> Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:615
> +- (BOOL)inAppBrowserPrivacyEnabled;

Ditto.

[Kate Cheney]

Created attachment 385919 [details]
Patch

[Kate Cheney]

(In reply to John Wilander from comment #3)
> Comment on attachment 385905 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385905&action=review
> 
> r+ with comments.
> 

Thanks John!

[WebKit Commit Bot]

Comment on attachment 385919 [details]
Patch

Clearing flags on attachment: 385919

Committed r253655: <https://trac.webkit.org/changeset/253655>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58024509>