Bug 205243

Summary:

python3: wpt exporter should parse a patch as bytes

Product:

WebKit

Reporter:

Emilio Cobos Álvarez (:emilio) <emilio>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, glenn, jbedard, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=184986

Attachments:

Description	Flags
Output of webkit-patch-upload -g HEAD	none
Patch	none

Emilio Cobos Álvarez (:emilio)

Reported 2019-12-14 19:44:24 PST

Created attachment 385706 [details] Output of webkit-patch-upload -g HEAD When trying to attach a patch to bug 117769, it threw, see the attached patch.

Attachments
Output of webkit-patch-upload -g HEAD (2.66 KB, text/plain) 2019-12-14 19:44 PST, Emilio Cobos Álvarez (:emilio)	no flags	Details
Patch (6.96 KB, patch) 2019-12-16 08:20 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Emilio Cobos Álvarez (:emilio)

Comment 1 2019-12-14 19:44:45 PST

(In reply to Emilio Cobos Álvarez (:emilio) from comment #0) > When trying to attach a patch to bug 117769, it threw, see the attached > patch. The attached output, that is :)

Jonathan Bedard

Comment 2 2019-12-16 07:48:25 PST

(In reply to Emilio Cobos Álvarez (:emilio) from comment #0) > Created attachment 385706 [details] > Output of webkit-patch-upload -g HEAD > > When trying to attach a patch to bug 117769, it threw, see the attached > patch. webkit-patch-upload isn't a WebKit script. Do you mean 'webkit-patch upload -g HEAD'?

Emilio Cobos Álvarez (:emilio)

Comment 3 2019-12-16 07:58:27 PST

Yes, sorry.

Jonathan Bedard

Comment 4 2019-12-16 08:20:31 PST

Created attachment 385770 [details] Patch

Jonathan Bedard

Comment 5 2019-12-16 08:22:38 PST

I don't actually have a git checkout, so I can't 100% replicate Emilio's configuration, but our unit tests were passing around patches as strings, which meant that we weren't correctly covering this case, so I'm pretty confident this is our fix.

WebKit Commit Bot

Comment 6 2019-12-16 15:01:14 PST

Comment on attachment 385770 [details] Patch Clearing flags on attachment: 385770 Committed r253587: <https://trac.webkit.org/changeset/253587>

WebKit Commit Bot

Comment 7 2019-12-16 15:01:15 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2019-12-16 15:02:39 PST

<rdar://problem/57986684>

Note You need to log in before you can comment on or make changes to this bug.