Summary: | Remove the "needsFullOrderingComparisons" feature from PODRedBlackTree | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||
Component: | WebCore Misc. | Assignee: | Darin Adler <darin> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, pdr, philipj, sam, sergio, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Darin Adler
2019-12-14 11:10:03 PST
Created attachment 385695 [details]
Patch
I am not able to reproduce the mac-wk2 EWS test failure locally. Re-running the test. Created attachment 386227 [details]
Patch
Comment on attachment 386227 [details]
Patch
Seems to me that the media/track/track-cue-rendering-horizontal.html must be a real regression. I wonder why i can’t reproduce it locally.
No that failure went away when I retried the EWS. Created attachment 387479 [details]
Patch
OK, worked around the Windows build failure, all tests are passing, so this is now ready for review. I have another patch to follow this one with further refinements, but I think it’s best to land this is smaller incremental steps. So I want to get this reviewed and landed as-is. Comment on attachment 387479 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387479&action=review > Source/WebCore/platform/PODInterval.h:3 > + * Copyright (C) 2019 Apple Inc. All rights reserved. 2020! Committed r254483: <https://trac.webkit.org/changeset/254483> |