Bug 205238

Summary: Remove the "needsFullOrderingComparisons" feature from PODRedBlackTree
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, pdr, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch sam: review+, sam: commit-queue+

Description Darin Adler 2019-12-14 11:10:03 PST
Remove the "needsFullOrderingComparisons" feature from PODRedBlackTree
Comment 1 Darin Adler 2019-12-14 11:20:49 PST Comment hidden (obsolete)
Comment 2 Darin Adler 2019-12-20 09:53:10 PST Comment hidden (obsolete)
Comment 3 Darin Adler 2019-12-20 11:11:01 PST Comment hidden (obsolete)
Comment 4 Darin Adler 2019-12-20 14:04:28 PST Comment hidden (obsolete)
Comment 5 Darin Adler 2020-01-02 16:23:26 PST Comment hidden (obsolete)
Comment 6 Darin Adler 2020-01-12 11:17:25 PST
Created attachment 387479 [details]
Patch
Comment 7 Darin Adler 2020-01-12 15:07:34 PST
OK, worked around the Windows build failure, all tests are passing, so this is now ready for review.
Comment 8 Darin Adler 2020-01-13 08:48:42 PST
I have another patch to follow this one with further refinements, but I think it’s best to land this is smaller incremental steps. So I want to get this reviewed and landed as-is.
Comment 9 Sam Weinig 2020-01-13 17:41:33 PST
Comment on attachment 387479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387479&action=review

> Source/WebCore/platform/PODInterval.h:3
> + * Copyright (C) 2019 Apple Inc. All rights reserved.

2020!
Comment 10 Darin Adler 2020-01-13 19:18:13 PST
Committed r254483: <https://trac.webkit.org/changeset/254483>
Comment 11 Radar WebKit Bug Importer 2020-01-13 19:19:10 PST
<rdar://problem/58554372>