Bug 205226

Summary: REGRSSION: [ High Sierra Catalina ] (r253310) compositing/video/video-border-radius-clipping.html is failing
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: CompositingAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, jlewis3, mjs, peng.liu6, philipj, sergio, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204951
https://bugs.webkit.org/show_bug.cgi?id=206614
Attachments:
Description Flags
Patch none

Truitt Savell
Reported 2019-12-13 16:16:22 PST
The changes in https://trac.webkit.org/changeset/253310/webkit has caused compositing/video/video-border-radius-clipping.html to become a constant failure on High Sierra and Catalina wk1 history: https://results.webkit.org/?suite=layout-tests&test=compositing%2Fvideo%2Fvideo-border-radius-clipping.html Diff: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r253485%20(17701)/compositing/video/video-border-radius-clipping-diffs.html Looks like a single pixel difference.
Attachments
Patch (7.25 KB, patch)
2020-01-27 13:31 PST, Peng Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-13 16:16:45 PST
<rdar://problem/57929456>
Simon Fraser (smfr)
Comment 2 2019-12-16 15:32:58 PST
I really wish we had per-test fuzziness for ref tests. These tests both use the same video, at the same time, but are off by a tiny bit.
Maciej Stachowiak
Comment 3 2019-12-16 16:00:00 PST
Maybe we should add per-test fuzziness?
Simon Fraser (smfr)
Comment 4 2019-12-16 16:20:26 PST
Alexey has historically objected: bug 149828.
Simon Fraser (smfr)
Comment 5 2019-12-17 13:48:23 PST
https://trac.webkit.org/changeset/253647/webkit
Alexey Proskuryakov
Comment 6 2020-01-22 23:26:03 PST
Why was this marked as RESOLVED/FIXED? Only an expectation was landed, there was no fix here.
Simon Fraser (smfr)
Comment 7 2020-01-23 13:38:46 PST
I marked as as a failure for those platforms (High Sierra, WK1) where it's flakey. We have test coverage on WK2/Mojave where it doesn't flake.
Alexey Proskuryakov
Comment 8 2020-01-23 14:31:08 PST
It flakes on WK2 too, see bug 206614.
Peng Liu
Comment 9 2020-01-27 13:31:10 PST
Created attachment 388894 [details] Patch
Alexey Proskuryakov
Comment 10 2020-01-27 13:39:27 PST
Comment on attachment 388894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388894&action=review > LayoutTests/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=205226 Is this expected to address https://bugs.webkit.org/show_bug.cgi?id=206614 too?
Peng Liu
Comment 11 2020-01-27 13:46:50 PST
*** Bug 206614 has been marked as a duplicate of this bug. ***
Peng Liu
Comment 12 2020-01-27 13:48:52 PST
(In reply to Alexey Proskuryakov from comment #10) > Comment on attachment 388894 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388894&action=review > > > LayoutTests/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=205226 > > Is this expected to address https://bugs.webkit.org/show_bug.cgi?id=206614 > too? I think so. I have verified that with my local build.
WebKit Commit Bot
Comment 13 2020-01-27 17:13:57 PST
Comment on attachment 388894 [details] Patch Clearing flags on attachment: 388894 Committed r255215: <https://trac.webkit.org/changeset/255215>
WebKit Commit Bot
Comment 14 2020-01-27 17:13:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.