Bug 205211

Summary: Add a Heap::finalize function that takes WTF::Function<void()>
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ggaren: review+
patch for landing none

Saam Barati
Reported 2019-12-13 11:37:52 PST
...
Attachments
patch (4.83 KB, patch)
2019-12-13 12:04 PST, Saam Barati 		ggaren: review+
DetailsFormatted DiffDiff
patch for landing (5.73 KB, patch)
2019-12-13 12:33 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-12-13 12:04:32 PST
Created attachment 385627 [details] patch This should work. Going to test it now.
Geoffrey Garen
Comment 2 2019-12-13 12:13:09 PST
Comment on attachment 385627 [details] patch r=me I would prefer to use a separate FinalizerOwner rather than bit masking the pointer because it would be a little clearer.
Saam Barati
Comment 3 2019-12-13 12:33:04 PST
Created attachment 385631 [details] patch for landing
WebKit Commit Bot
Comment 4 2019-12-13 14:37:59 PST
Comment on attachment 385631 [details] patch for landing Clearing flags on attachment: 385631 Committed r253500: <https://trac.webkit.org/changeset/253500>
WebKit Commit Bot
Comment 5 2019-12-13 14:38:01 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-12-13 14:38:31 PST
<rdar://problem/57925827>
Note You need to log in before you can comment on or make changes to this bug.