Bug 205169

Summary: SecurityOrigin should be unique for null blob URLs that have been unregistered
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, commit-queue, darin, dbates, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2019-12-12 09:49:20 PST
SecurityOrigin should be unique for null blob URLs that have been unregistered
Attachments
Patch (6.06 KB, patch)
2019-12-12 09:51 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (6.06 KB, patch)
2019-12-12 10:43 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (7.05 KB, patch)
2019-12-12 11:38 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (7.01 KB, patch)
2019-12-13 06:35 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (6.07 KB, patch)
2019-12-13 07:42 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.09 KB, patch)
2019-12-15 23:15 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-12-12 09:51:32 PST
Created attachment 385504 [details] Patch
youenn fablet
Comment 2 2019-12-12 10:43:02 PST
Created attachment 385513 [details] Patch
youenn fablet
Comment 3 2019-12-12 11:38:08 PST
Created attachment 385518 [details] Patch
youenn fablet
Comment 4 2019-12-13 06:35:11 PST
Created attachment 385598 [details] Patch
youenn fablet
Comment 5 2019-12-13 07:30:41 PST
<rdar://problem/57827825>
youenn fablet
Comment 6 2019-12-13 07:42:55 PST
Created attachment 385601 [details] Patch
Darin Adler
Comment 7 2019-12-13 13:57:04 PST
Comment on attachment 385601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385601&action=review > Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:166 > + if (!url.protocolIsBlob() || BlobURL::getOrigin(url) != "null") > + return nullptr; Seems like the special name "null" should be gotten from calling a function rather than a hardcoded string constant.
youenn fablet
Comment 8 2019-12-15 23:15:03 PST
Created attachment 385739 [details] Patch for landing
youenn fablet
Comment 9 2019-12-15 23:16:00 PST
(In reply to Darin Adler from comment #7) > Comment on attachment 385601 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385601&action=review > > > Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:166 > > + if (!url.protocolIsBlob() || BlobURL::getOrigin(url) != "null") > > + return nullptr; > > Seems like the special name "null" should be gotten from calling a function > rather than a hardcoded string constant. I introduced a helper routine isBlobURLContainsNullOrigin.
WebKit Commit Bot
Comment 10 2019-12-16 03:04:48 PST
Comment on attachment 385739 [details] Patch for landing Clearing flags on attachment: 385739 Committed r253544: <https://trac.webkit.org/changeset/253544>
WebKit Commit Bot
Comment 11 2019-12-16 03:04:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.