Summary: | SecurityOrigin should be unique for null blob URLs that have been unregistered | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||
Component: | Page Loading | Assignee: | youenn fablet <youennf> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | achristensen, beidson, bfulgham, commit-queue, darin, dbates, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
youenn fablet
2019-12-12 09:49:20 PST
Created attachment 385504 [details]
Patch
Created attachment 385513 [details]
Patch
Created attachment 385518 [details]
Patch
Created attachment 385598 [details]
Patch
Created attachment 385601 [details]
Patch
Comment on attachment 385601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385601&action=review > Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:166 > + if (!url.protocolIsBlob() || BlobURL::getOrigin(url) != "null") > + return nullptr; Seems like the special name "null" should be gotten from calling a function rather than a hardcoded string constant. Created attachment 385739 [details]
Patch for landing
(In reply to Darin Adler from comment #7) > Comment on attachment 385601 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385601&action=review > > > Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:166 > > + if (!url.protocolIsBlob() || BlobURL::getOrigin(url) != "null") > > + return nullptr; > > Seems like the special name "null" should be gotten from calling a function > rather than a hardcoded string constant. I introduced a helper routine isBlobURLContainsNullOrigin. Comment on attachment 385739 [details] Patch for landing Clearing flags on attachment: 385739 Committed r253544: <https://trac.webkit.org/changeset/253544> All reviewed patches have been landed. Closing bug. |