Bug 205152

Summary: [JSC] IsoHeapCellType should have destroy function member instead of specializing template function
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2019-12-11 19:54:19 PST
[JSC] IsoHeapCellType should have destroy function member instead of specializing template function
Attachments
Patch (53.94 KB, patch)
2019-12-11 20:01 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (43.63 KB, patch)
2019-12-11 20:11 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-12-11 20:01:53 PST
Created attachment 385473 [details] Patch
Yusuke Suzuki
Comment 2 2019-12-11 20:11:03 PST
Created attachment 385474 [details] Patch
Radar WebKit Bug Importer
Comment 3 2019-12-11 20:11:30 PST
<rdar://problem/57865102>
Saam Barati
Comment 4 2019-12-11 21:15:03 PST
Comment on attachment 385474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385474&action=review > Source/JavaScriptCore/heap/IsoHeapCellType.cpp:2 > + * Copyright (C) 2017 Apple Inc. All rights reserved. 2019? > Source/JavaScriptCore/inspector/PerGlobalObjectWrapperWorld.cpp:31 > +using namespace JSC; Why all of these?
Yusuke Suzuki
Comment 5 2019-12-12 01:35:43 PST
Comment on attachment 385474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385474&action=review >> Source/JavaScriptCore/heap/IsoHeapCellType.cpp:2 >> + * Copyright (C) 2017 Apple Inc. All rights reserved. > > 2019? Fixed. >> Source/JavaScriptCore/inspector/PerGlobalObjectWrapperWorld.cpp:31 >> +using namespace JSC; > > Why all of these? ChangeLog describes the reason :) This patch also removes `using namespace JSC;` in global code in JavaScriptCore except for API codes, since it starts causing build failure due to unified builds: API defines JSType enum in a global scope, which is different from our JSC::JSType. If we do `using namespace JSC;` in a global scope, it can lead to ambiguity of looking up.
Yusuke Suzuki
Comment 6 2019-12-12 01:36:18 PST
Committed r253423: <https://trac.webkit.org/changeset/253423>
Note You need to log in before you can comment on or make changes to this bug.