Bug 205141

Summary: WebGLRenderingContext.texImage2D() should respect EXIF orientation
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, mjs, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Said Abou-Hallawa 2019-12-11 15:39:14 PST 
If the EXIF orientation is present in an Image, WebGLRenderingContext.texImage2D() needs to draw this image into an ImageBuffer, makes a temporary Image object from the ImageBuffer then draw this temporary image to the WebGL texture. Drawing an image to an ImageBuffer respects the EXIF orientation of the original image. WebGLRenderingContext also does the same trick when drawing an SVGImage.
Comment 1 Said Abou-Hallawa 2019-12-11 15:44:34 PST 
Created attachment 385453 [details]
Patch
Comment 2 Said Abou-Hallawa 2019-12-11 15:46:43 PST 
<rdar://problem/57370489>
Comment 3 Said Abou-Hallawa 2019-12-16 15:34:19 PST 
Created attachment 385821 [details]
Patch
Comment 4 Said Abou-Hallawa 2019-12-16 17:36:33 PST 
Created attachment 385838 [details]
Patch
Comment 5 Maciej Stachowiak 2019-12-16 19:05:02 PST 
Comment on attachment 385838 [details]
Patch

r=me
Comment 6 Maciej Stachowiak 2019-12-16 19:05:32 PST 
(Looks like Simon reviewed already so never mind.)
Comment 7 WebKit Commit Bot 2019-12-16 21:36:22 PST 
Comment on attachment 385838 [details]
Patch

Clearing flags on attachment: 385838

Committed r253610: <https://trac.webkit.org/changeset/253610>
Comment 8 WebKit Commit Bot 2019-12-16 21:36:24 PST 
All reviewed patches have been landed.  Closing bug.