Bug 205141

Summary: WebGLRenderingContext.texImage2D() should respect EXIF orientation
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kondapallykalyan, mjs, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Said Abou-Hallawa
Reported 2019-12-11 15:39:14 PST
If the EXIF orientation is present in an Image, WebGLRenderingContext.texImage2D() needs to draw this image into an ImageBuffer, makes a temporary Image object from the ImageBuffer then draw this temporary image to the WebGL texture. Drawing an image to an ImageBuffer respects the EXIF orientation of the original image. WebGLRenderingContext also does the same trick when drawing an SVGImage.
Attachments
Patch (16.41 KB, patch)
2019-12-11 15:44 PST, Said Abou-Hallawa
no flags
Patch (29.78 KB, patch)
2019-12-16 15:34 PST, Said Abou-Hallawa
no flags
Patch (30.50 KB, patch)
2019-12-16 17:36 PST, Said Abou-Hallawa
no flags
Said Abou-Hallawa
Comment 1 2019-12-11 15:44:34 PST
Said Abou-Hallawa
Comment 2 2019-12-11 15:46:43 PST
Said Abou-Hallawa
Comment 3 2019-12-16 15:34:19 PST
Said Abou-Hallawa
Comment 4 2019-12-16 17:36:33 PST
Maciej Stachowiak
Comment 5 2019-12-16 19:05:02 PST
Comment on attachment 385838 [details] Patch r=me
Maciej Stachowiak
Comment 6 2019-12-16 19:05:32 PST
(Looks like Simon reviewed already so never mind.)
WebKit Commit Bot
Comment 7 2019-12-16 21:36:22 PST
Comment on attachment 385838 [details] Patch Clearing flags on attachment: 385838 Committed r253610: <https://trac.webkit.org/changeset/253610>
WebKit Commit Bot
Comment 8 2019-12-16 21:36:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.