Bug 205127

Summary: [iOS] Issue load sooner on swipe back/forward navigation
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, simon.fraser, thorton, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 205087, 205173    
Bug Blocks:    
Attachments:
Description Flags
WIP Patch
none
Patch none

Chris Dumez
Reported 2019-12-11 10:51:33 PST
Issue load sooner on swipe back/forward navigation on iOS. We currently wait until the end of the swipe animation to issue the load but we should be able to start loading as soon as the user lifts the finger and thus commits to navigating. This will improve perceived performance on swipe back/forward navigation.
Attachments
WIP Patch (7.53 KB, patch)
2019-12-11 10:52 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (9.09 KB, patch)
2019-12-11 12:11 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-11 10:51:52 PST
<rdar://problem/57843862>
Chris Dumez
Comment 2 2019-12-11 10:52:20 PST
Created attachment 385409 [details] WIP Patch
Chris Dumez
Comment 3 2019-12-11 12:11:50 PST
Created attachment 385421 [details] Patch
WebKit Commit Bot
Comment 4 2019-12-11 14:04:23 PST
Comment on attachment 385421 [details] Patch Clearing flags on attachment: 385421 Committed r253394: <https://trac.webkit.org/changeset/253394>
WebKit Commit Bot
Comment 5 2019-12-11 14:04:25 PST
All reviewed patches have been landed. Closing bug.
Truitt Savell
Comment 6 2019-12-12 09:41:25 PST
It looks like the changes in https://trac.webkit.org/changeset/253394/webkit has caused swipe/basic-cached-back-swipe.html to timeout on iOS History: https://results.webkit.org/?suite=layout-tests&test=swipe%2Fbasic-cached-back-swipe.html
Chris Dumez
Comment 7 2019-12-12 09:47:57 PST
(In reply to Truitt Savell from comment #6) > It looks like the changes in https://trac.webkit.org/changeset/253394/webkit > > has caused swipe/basic-cached-back-swipe.html to timeout on iOS > > History: > https://results.webkit.org/?suite=layout-tests&test=swipe%2Fbasic-cached- > back-swipe.html Looking now.
Chris Dumez
Comment 8 2019-12-12 11:54:55 PST
(In reply to Chris Dumez from comment #7) > (In reply to Truitt Savell from comment #6) > > It looks like the changes in https://trac.webkit.org/changeset/253394/webkit > > > > has caused swipe/basic-cached-back-swipe.html to timeout on iOS > > > > History: > > https://results.webkit.org/?suite=layout-tests&test=swipe%2Fbasic-cached- > > back-swipe.html > > Looking now. ViewGestureController::willEndSwipeGesture() does not get called in the context on the test. We see beginSwipeGesture and then endSwipeGesture though. As a result, we do not schedule the navigation.
Note You need to log in before you can comment on or make changes to this bug.