Bug 205115

Summary: [LFC][IFC] Fix fast/text/hyphenate-limit-lines.html
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

zalan
Reported 2019-12-11 08:08:27 PST
handle the hyphenated line count properly
Attachments
Patch (2.22 KB, patch)
2019-12-11 08:16 PST, zalan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-11 08:08:50 PST
<rdar://problem/57837829>
zalan
Comment 2 2019-12-11 08:16:19 PST
Created attachment 385393 [details] Patch
Antti Koivisto
Comment 3 2019-12-11 08:23:03 PST
Comment on attachment 385393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385393&action=review > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:246 > + m_successiveHyphenatedLineCount = breakingContext.partialTrailingContent && breakingContext.partialTrailingContent->needsHyphen ? m_successiveHyphenatedLineCount + 1 : 0; Might read better as if()
Antti Koivisto
Comment 4 2019-12-11 08:24:05 PST
if() ++m_successiveHyphenatedLineCount; else m_successiveHyphenatedLineCount = 0;
zalan
Comment 5 2019-12-11 08:36:09 PST
Committed r253373: <https://trac.webkit.org/changeset/253373>
zalan
Comment 6 2019-12-11 08:45:57 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 385393 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385393&action=review > > > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:246 > > + m_successiveHyphenatedLineCount = breakingContext.partialTrailingContent && breakingContext.partialTrailingContent->needsHyphen ? m_successiveHyphenatedLineCount + 1 : 0; > > Might read better as if() good point!
Note You need to log in before you can comment on or make changes to this bug.