Bug 205108

Summary: [JSC] Lock-down JSGlobalObject and derived classes in IsoSubspace
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, eric.carlson, ews-watchlist, glenn, jer.noble, jsbell, keith_miller, mark.lam, msaboff, philipj, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
mark.lam: review+
Patch
none
Patch
none
Patch
none
Patch none

Yusuke Suzuki
Reported 2019-12-11 03:19:51 PST
...
Attachments
Patch (34.05 KB, patch)
2019-12-11 03:23 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (40.35 KB, patch)
2019-12-11 03:43 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (96.27 KB, patch)
2019-12-11 03:54 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (99.56 KB, patch)
2019-12-11 04:07 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (99.66 KB, patch)
2019-12-11 04:22 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (99.67 KB, patch)
2019-12-11 04:33 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Patch (104.67 KB, patch)
2019-12-11 15:10 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (104.71 KB, patch)
2019-12-11 15:24 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (105.59 KB, patch)
2019-12-12 03:15 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (106.88 KB, patch)
2019-12-12 03:33 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-12-11 03:23:10 PST
Created attachment 385372 [details] Patch
Yusuke Suzuki
Comment 2 2019-12-11 03:43:16 PST
Created attachment 385376 [details] Patch
Yusuke Suzuki
Comment 3 2019-12-11 03:54:17 PST
Created attachment 385377 [details] Patch
Yusuke Suzuki
Comment 4 2019-12-11 04:07:45 PST
Created attachment 385379 [details] Patch
Yusuke Suzuki
Comment 5 2019-12-11 04:22:15 PST
Created attachment 385380 [details] Patch
Yusuke Suzuki
Comment 6 2019-12-11 04:33:12 PST
Created attachment 385381 [details] Patch
Mark Lam
Comment 7 2019-12-11 09:17:46 PST
Comment on attachment 385381 [details] Patch r=me. Please fix the win bots failure (probably just need a JS_EXPORT_PRIVATE attribute on 2 functions according to wincairo bot). The jsc EWS says testapi is failing. Looks legit. Please fix before landing.
Yusuke Suzuki
Comment 8 2019-12-11 14:20:32 PST
(In reply to Mark Lam from comment #7) > Comment on attachment 385381 [details] > Patch > > r=me. > > Please fix the win bots failure (probably just need a JS_EXPORT_PRIVATE > attribute on 2 functions according to wincairo bot). The jsc EWS says > testapi is failing. Looks legit. Please fix before landing. Yeah, right. Annotated, and fixed the testapi.
Yusuke Suzuki
Comment 9 2019-12-11 15:10:37 PST
Created attachment 385446 [details] Patch Patch for landing
Yusuke Suzuki
Comment 10 2019-12-11 15:24:01 PST
Created attachment 385448 [details] Patch Patch for landing
Yusuke Suzuki
Comment 11 2019-12-12 03:15:47 PST
Created attachment 385487 [details] Patch Patch for landing
Yusuke Suzuki
Comment 12 2019-12-12 03:33:53 PST
Created attachment 385488 [details] Patch Patch for landing
Yusuke Suzuki
Comment 13 2019-12-12 13:34:00 PST
Committed r253443: <https://trac.webkit.org/changeset/253443>
Radar WebKit Bug Importer
Comment 14 2019-12-12 13:34:24 PST
<rdar://problem/57889778>
Note You need to log in before you can comment on or make changes to this bug.