Bug 205095

Summary: IndexedDB: Introduce WebIDBServer class
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, annulen, beidson, cdumez, cgarcia, commit-queue, ews-watchlist, gyuyoung.kim, jsbell, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Sihui Liu
Reported 2019-12-10 17:04:05 PST
We have InProcessIDBServer in WebKitLegacy, now we create WebIDBServer which owns IDBServer in WebKit. This is a step to https://bugs.webkit.org/show_bug.cgi?id=203690.
Attachments
Patch (39.00 KB, patch)
2019-12-10 17:11 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (44.31 KB, patch)
2019-12-10 17:17 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (38.14 KB, patch)
2019-12-10 17:22 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (38.28 KB, patch)
2019-12-11 08:59 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (39.04 KB, patch)
2019-12-11 10:47 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2019-12-10 17:11:38 PST
Created attachment 385322 [details] Patch
Sihui Liu
Comment 2 2019-12-10 17:17:34 PST
Created attachment 385323 [details] Patch
Sihui Liu
Comment 3 2019-12-10 17:22:05 PST
Created attachment 385325 [details] Patch
Sihui Liu
Comment 4 2019-12-11 08:59:15 PST
Created attachment 385397 [details] Patch
Alex Christensen
Comment 5 2019-12-11 09:20:40 PST
Comment on attachment 385397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385397&action=review > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:90 > + RefPtr<WebCore::IDBServer::IDBServer> m_server; This could be a Ref. > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:91 > + bool m_isSuspended { false }; This could be wrapped in #if !ASSERT_DISABLED Not too important, though.
Sihui Liu
Comment 6 2019-12-11 10:14:45 PST
(In reply to Alex Christensen from comment #5) > Comment on attachment 385397 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385397&action=review > > > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:90 > > + RefPtr<WebCore::IDBServer::IDBServer> m_server; > > This could be a Ref. Sure. > > > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:91 > > + bool m_isSuspended { false }; > > This could be wrapped in #if !ASSERT_DISABLED > Not too important, though. I was meant to use this for early return in WebIDBServer::suspend. Will add that!
Sihui Liu
Comment 7 2019-12-11 10:47:44 PST
Created attachment 385407 [details] Patch
WebKit Commit Bot
Comment 8 2019-12-11 13:47:52 PST
Comment on attachment 385407 [details] Patch Clearing flags on attachment: 385407 Committed r253393: <https://trac.webkit.org/changeset/253393>
WebKit Commit Bot
Comment 9 2019-12-11 13:47:55 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-12-11 13:48:20 PST
<rdar://problem/57851867>
Note You need to log in before you can comment on or make changes to this bug.