Summary: | IndexedDB: Introduce WebIDBServer class | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||||||
Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, alecflett, annulen, beidson, cdumez, cgarcia, commit-queue, ews-watchlist, gyuyoung.kim, jsbell, ryuan.choi, sergio, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Sihui Liu
2019-12-10 17:04:05 PST
Created attachment 385322 [details]
Patch
Created attachment 385323 [details]
Patch
Created attachment 385325 [details]
Patch
Created attachment 385397 [details]
Patch
Comment on attachment 385397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385397&action=review > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:90 > + RefPtr<WebCore::IDBServer::IDBServer> m_server; This could be a Ref. > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:91 > + bool m_isSuspended { false }; This could be wrapped in #if !ASSERT_DISABLED Not too important, though. (In reply to Alex Christensen from comment #5) > Comment on attachment 385397 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385397&action=review > > > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:90 > > + RefPtr<WebCore::IDBServer::IDBServer> m_server; > > This could be a Ref. Sure. > > > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:91 > > + bool m_isSuspended { false }; > > This could be wrapped in #if !ASSERT_DISABLED > Not too important, though. I was meant to use this for early return in WebIDBServer::suspend. Will add that! Created attachment 385407 [details]
Patch
Comment on attachment 385407 [details] Patch Clearing flags on attachment: 385407 Committed r253393: <https://trac.webkit.org/changeset/253393> All reviewed patches have been landed. Closing bug. |