Bug 205056 – Add support for Audio Capture in GPUProcess

• Component: WebRTC
• Status: RESOLVED FIXED

[youenn fablet]

Add support for Audio Capture in GPUProcess

[youenn fablet]

Created attachment 385249 [details]
Patch

[youenn fablet]

Created attachment 385880 [details]
Patch

[Eric Carlson]

Comment on attachment 385880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385880&action=review

> Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:96
> +    if (m_disableAudioSessionCheck) {

Do you mean "if (!m_disableAudioSessionCheck)" ?

[youenn fablet]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 385880 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385880&action=review
> 
> > Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:96
> > +    if (m_disableAudioSessionCheck) {
> 
> Do you mean "if (!m_disableAudioSessionCheck)" ?

Right!

[youenn fablet]

(In reply to youenn fablet from comment #4)
> (In reply to Eric Carlson from comment #3)
> > Comment on attachment 385880 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=385880&action=review
> > 
> > > Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:96
> > > +    if (m_disableAudioSessionCheck) {
> > 
> > Do you mean "if (!m_disableAudioSessionCheck)" ?
> 
> Right!

Need to hook in WTR crash reports with the GPU process.

[youenn fablet]

Created attachment 385882 [details]
Patch

[Eric Carlson]

Comment on attachment 385882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385882&action=review

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:80
> +    , m_userMediaCaptureManagerProxy(makeUnique<UserMediaCaptureManagerProxy>(makeUniqueRef<GPUProxyForCapture>(*this)))

Can we allocate this lazily?

[youenn fablet]

Created attachment 385977 [details]
Patch for landing

[youenn fablet]

(In reply to Eric Carlson from comment #7)
> Comment on attachment 385882 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385882&action=review
> 
> > Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:80
> > +    , m_userMediaCaptureManagerProxy(makeUnique<UserMediaCaptureManagerProxy>(makeUniqueRef<GPUProxyForCapture>(*this)))
> 
> Can we allocate this lazily?

Done, thanks!

[WebKit Commit Bot]

Comment on attachment 385977 [details]
Patch for landing

Clearing flags on attachment: 385977

Committed r253705: <https://trac.webkit.org/changeset/253705>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58051486>

[Truitt Savell]

Looks like the changes in https://trac.webkit.org/changeset/253705/webkit
brok a test, tracking in https://bugs.webkit.org/show_bug.cgi?id=205455

[youenn fablet]

(In reply to Truitt Savell from comment #13)
> Looks like the changes in https://trac.webkit.org/changeset/253705/webkit
> brok a test, tracking in https://bugs.webkit.org/show_bug.cgi?id=205455

Will be fixed by https://bugs.webkit.org/show_bug.cgi?id=205492