Bug 205039

Summary: Web Inspector: Elements: Styles: hovering over an invalid value while holding ⌘ doesn't change the color of the text
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
bburg: review+
Patch
none
Patch none

Devin Rousso
Reported 2019-12-09 17:02:33 PST
Normally, when hovering over any name/value while holding ⌘, the text turns blue and an underline appears, meaning that when the hovered text is clicked, the user is taken to the source code location for that text in the Sources Tab. When hovering an invalid value, however, this coloration doesn't happen. ``` color: "this should fail"; ```
Attachments
Patch (6.06 KB, patch)
2019-12-09 17:04 PST, Devin Rousso 		bburg: review+
DetailsFormatted DiffDiff
Patch (9.51 KB, patch)
2019-12-10 21:43 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (12.55 KB, patch)
2019-12-10 22:14 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-12-09 17:04:46 PST
Created attachment 385212 [details] Patch
Blaze Burg
Comment 2 2019-12-10 12:10:53 PST
Comment on attachment 385212 [details] Patch r=me It still seems a bit wonky if you hover a property value and then press command. In that case, not all of the other properties and values in the section get the underlining until mouse hover leaves and re-enters the entire section. But this part is not a regression. Can you see if you are able to repro that behavior?
Devin Rousso
Comment 3 2019-12-10 21:43:18 PST
Created attachment 385343 [details] Patch (In reply to Brian Burg from comment #2) > It still seems a bit wonky if you hover a property value and then press command. In that case, not all of the other properties and values in the section get the underlining until mouse hover leaves and re-enters the entire section. But this part is not a regression. Can you see if you are able to repro that behavior? I was able to reproduce the behavior as you describe, and I think I was able to fix it by being more specific as to when we apply _any_ CSS rule that involves color.
Devin Rousso
Comment 4 2019-12-10 22:14:24 PST
Created attachment 385350 [details] Patch
Blaze Burg
Comment 5 2019-12-11 15:46:35 PST
Comment on attachment 385350 [details] Patch r=me Works much better now, thank you!
WebKit Commit Bot
Comment 6 2019-12-11 16:40:59 PST
Comment on attachment 385350 [details] Patch Clearing flags on attachment: 385350 Committed r253405: <https://trac.webkit.org/changeset/253405>
WebKit Commit Bot
Comment 7 2019-12-11 16:41:01 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-12-11 16:41:18 PST
<rdar://problem/57859655>
Note You need to log in before you can comment on or make changes to this bug.