Summary: | Web Inspector: REGRESSION(r251038): Elements: Computed: implicit shorthands are not shown when "Prefer Shorthands" is enabled | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 200554 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Nikita Vasilyev
2019-12-09 16:23:37 PST
Reduction: https://nv.github.io/webkit-inspector-bugs/205035_computed-shortcuts-bug/index.html This regressed in Bug 200554 Web Inspector: Elements: Computed: show shorthand properties in addition to longhand ones Created attachment 385218 [details]
Patch
Comment on attachment 385218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385218&action=review r=me > Source/WebInspectorUI/ChangeLog:17 > + Drive-by: filter the list of properties to render before sorting them for performance. Does this affect the display order? Is it already being sorted? > Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:170 > + if (!(this._showsShorthandsInsteadOfLonghands && property.isShorthand && hasNonImplicitLonghand(property))) I wish it were possible to fold this into the guard below, but alas, it early exits too early otherwise. Comment on attachment 385218 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385218&action=review >> Source/WebInspectorUI/ChangeLog:17 >> + Drive-by: filter the list of properties to render before sorting them for performance. > > Does this affect the display order? Is it already being sorted? No, it was already sorted. What I mean by saying this is rather than sort-then-filter, we filter-then-sort so we don't have to sort as many items :P >> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:170 >> + if (!(this._showsShorthandsInsteadOfLonghands && property.isShorthand && hasNonImplicitLonghand(property))) > > I wish it were possible to fold this into the guard below, but alas, it early exits too early otherwise. Indeed :( The commit-queue encountered the following flaky tests while processing attachment 385218 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 385218 [details] Patch Clearing flags on attachment: 385218 Committed r253348: <https://trac.webkit.org/changeset/253348> All reviewed patches have been landed. Closing bug. |