Bug 205034

Summary: REGRESSION(r252523): Web Inspector: Styles: semicolon is wrongly positioned in multiline values
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 203754    
Bug Blocks:    
Attachments:
Description Flags
[image] Bug
none
Patch none

Nikita Vasilyev
Reported 2019-12-09 16:11:31 PST
Created attachment 385203 [details] [image] Bug The semicolon should immediately follow the last character of the value.
Attachments
[image] Bug (48.28 KB, image/png)
2019-12-09 16:11 PST, Nikita Vasilyev 		no flags
Details
Patch (3.28 KB, patch)
2019-12-09 16:59 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-09 16:11:57 PST
<rdar://problem/57772846>
Devin Rousso
Comment 2 2019-12-09 16:59:52 PST
Created attachment 385211 [details] Patch
Nikita Vasilyev
Comment 3 2019-12-09 18:38:40 PST
Comment on attachment 385211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385211&action=review This fixes the bug. > Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:186 > - this._valueElement = this._contentElement.appendChild(document.createElement("span")); > + let valueContainer = this._contentElement.appendChild(document.createElement("span")); > + valueContainer.className = "value-container"; > + > + this._valueElement = valueContainer.appendChild(document.createElement("span")); This looks fine — I don't know how to resolve this without introducing the wrapper element ("value-container").
Blaze Burg
Comment 4 2019-12-10 11:39:16 PST
Comment on attachment 385211 [details] Patch r=me
WebKit Commit Bot
Comment 5 2019-12-10 12:09:36 PST
Comment on attachment 385211 [details] Patch Clearing flags on attachment: 385211 Committed r253338: <https://trac.webkit.org/changeset/253338>
WebKit Commit Bot
Comment 6 2019-12-10 12:09:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.