Bug 205032

Summary: Make incremental builds faster after modifying DisplayListItems.h
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, ews-watchlist, gyuyoung.kim, ryuan.choi, sabouhallawa, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Depends on webkit.org/b/204955
none
Patch
none
Patch
thorton: review+
For EWS none

Wenson Hsieh
Reported 2019-12-09 16:03:52 PST
Touching DisplayListItems.h (typically for the purposes of adding or adjusting encoding/decoding logic) currently dirties DisplayList.h, which goes on to dirty a handful of other files in WebCore (which could grow in number in the near future). Move a bit of logic around to minimize the number of files that need to be recompiled as a result of modifying this header.
Attachments
Depends on webkit.org/b/204955 (11.88 KB, patch)
2019-12-09 16:11 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (11.25 KB, patch)
2019-12-11 08:07 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (11.77 KB, patch)
2019-12-11 08:22 PST, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
For EWS (9.75 KB, patch)
2019-12-11 09:22 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-12-09 16:11:52 PST Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2019-12-11 08:07:15 PST Comment hidden (obsolete)
Wenson Hsieh
Comment 3 2019-12-11 08:22:22 PST Comment hidden (obsolete)
Tim Horton
Comment 4 2019-12-11 08:44:36 PST
Comment on attachment 385394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385394&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:-159 > -class DrawingItem : public Item { Does DL.h actually need drawing item or just item?
Wenson Hsieh
Comment 5 2019-12-11 09:19:41 PST
Comment on attachment 385394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385394&action=review >> Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:-159 >> -class DrawingItem : public Item { > > Does DL.h actually need drawing item or just item? Oh good point — it just needs DisplayList::Item, not DisplayList::DrawingItem. I moved DrawingItem back into DisplayListItems.h.
Wenson Hsieh
Comment 6 2019-12-11 09:22:57 PST
Created attachment 385401 [details] For EWS
WebKit Commit Bot
Comment 7 2019-12-11 10:42:32 PST
Comment on attachment 385401 [details] For EWS Clearing flags on attachment: 385401 Committed r253380: <https://trac.webkit.org/changeset/253380>
Note You need to log in before you can comment on or make changes to this bug.