Bug 205018

Summary: Finish encoding/decoding support for DisplayList::SetState
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, justin_fan, sabouhallawa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP for EWS
none
Fix GTK/WPE & rebaseline a test
none
Rebaseline more tests none

Wenson Hsieh
Reported 2019-12-09 10:11:29 PST
Many fields are currently not being encoded/decoded in SetState.
Attachments
WIP for EWS (34.89 KB, patch)
2019-12-09 11:06 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix GTK/WPE & rebaseline a test (36.12 KB, patch)
2019-12-09 12:05 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Rebaseline more tests (37.55 KB, patch)
2019-12-09 12:53 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-12-09 11:06:54 PST
Created attachment 385170 [details] WIP for EWS
Tim Horton
Comment 2 2019-12-09 11:16:08 PST
Comment on attachment 385170 [details] WIP for EWS View in context: https://bugs.webkit.org/attachment.cgi?id=385170&action=review > Source/WebCore/ChangeLog:27 > + Remove ShadowColorChange, which was unused; instead, shadow color changes are indicated by the ShadowChange > + flag, which also encompasses shadow offset and blur. Weird, wonder what that was for
Wenson Hsieh
Comment 3 2019-12-09 12:04:10 PST
Comment on attachment 385170 [details] WIP for EWS View in context: https://bugs.webkit.org/attachment.cgi?id=385170&action=review (It looks like I have a test to rebaseline after changing the Change flags). >> Source/WebCore/ChangeLog:27 >> + flag, which also encompasses shadow offset and blur. > > Weird, wonder what that was for Unsure! It looks like this was added several years ago in r194708, but was, AFAICT, unused. Changes in shadow color were instead flagged using ShadowChange.
Wenson Hsieh
Comment 4 2019-12-09 12:05:59 PST Comment hidden (obsolete)
Wenson Hsieh
Comment 5 2019-12-09 12:53:35 PST
Created attachment 385180 [details] Rebaseline more tests
WebKit Commit Bot
Comment 6 2019-12-09 14:53:34 PST
Comment on attachment 385180 [details] Rebaseline more tests Clearing flags on attachment: 385180 Committed r253302: <https://trac.webkit.org/changeset/253302>
WebKit Commit Bot
Comment 7 2019-12-09 14:53:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-12-09 14:54:48 PST
<rdar://problem/57769821>
Note You need to log in before you can comment on or make changes to this bug.