Bug 204982

Summary: [LFC][Integration] Layout test assert and crash fixes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
zalan: review+
patch none

Description Antti Koivisto 2019-12-07 02:59:18 PST 
Fixes for common integration related assertion failures with LFC enabled.
Comment 1 Antti Koivisto 2019-12-07 03:06:22 PST 
Created attachment 385089 [details]
patch
Comment 2 Antti Koivisto 2019-12-07 03:10:07 PST 
Created attachment 385090 [details]
patch
Comment 3 zalan 2019-12-07 04:39:32 PST 
Comment on attachment 385090 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385090&action=review

> Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:197
> +            childLayoutBox = makeUnique<Box>(elementAttributes(renderer), RenderStyle::clone(renderer.style()));

lol
Comment 4 Antti Koivisto 2019-12-07 05:30:26 PST 
Created attachment 385095 [details]
patch
Comment 5 WebKit Commit Bot 2019-12-07 05:56:59 PST 
Comment on attachment 385095 [details]
patch

Clearing flags on attachment: 385095

Committed r253251: <https://trac.webkit.org/changeset/253251>
Comment 6 WebKit Commit Bot 2019-12-07 05:57:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-07 05:57:19 PST 
<rdar://problem/57727271>