Bug 204969

Summary: Turn on TestWebKitAPI.WKAttachmentTests.CopyAndPasteBetweenWebViews as it is now passing again.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, bdakin, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Megan Gardner
Reported 2019-12-06 18:04:42 PST
Turn on TestWebKitAPI.WebKit2CustomProtocolsTest.CloseDuringCustomProtocolLoad as it is now passing again.
Attachments
Patch (1.99 KB, patch)
2019-12-06 18:06 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (1.82 KB, patch)
2020-03-17 11:20 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (1.85 KB, patch)
2021-08-17 17:35 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2019-12-06 18:06:08 PST
Created attachment 385073 [details] Patch
Wenson Hsieh
Comment 2 2019-12-06 19:52:50 PST
<rdar://problem/51752593>
Wenson Hsieh
Comment 3 2019-12-06 19:53:20 PST
Comment on attachment 385073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385073&action=review > Tools/ChangeLog:3 > + Turn on TestWebKitAPI.WebKit2CustomProtocolsTest.CloseDuringCustomProtocolLoad as it is now passing again. Nit - WKAttachmentTests.CopyAndPasteBetweenWebViews?
Alexey Proskuryakov
Comment 4 2019-12-07 13:19:27 PST
Comment on attachment 385073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385073&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:-1493 > -#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED < 130000 EWS says that it's still failing :(
Megan Gardner
Comment 5 2020-03-17 11:20:42 PDT
Created attachment 393769 [details] Patch
Alexey Proskuryakov
Comment 6 2020-05-06 10:00:12 PDT
It still failed with the latest patch.
Megan Gardner
Comment 7 2021-08-17 17:35:17 PDT
Created attachment 435730 [details] Patch
EWS
Comment 8 2021-08-19 15:32:56 PDT
Committed r281275 (240700@main): <https://commits.webkit.org/240700@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435730 [details].
Note You need to log in before you can comment on or make changes to this bug.