Bug 204945

Summary: Support different resolutions for video tracks captured from UIProcess
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, hta, jbedard, jer.noble, jlewis3, philipj, sergio, tommyw, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2019-12-06 05:01:29 PST
Support different resolutions for video tracks captured from UIProcess
Attachments
Patch (24.56 KB, patch)
2019-12-06 05:08 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (29.79 KB, patch)
2019-12-06 07:48 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (24.67 KB, patch)
2019-12-06 09:03 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.70 KB, patch)
2019-12-08 08:08 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-12-06 05:08:59 PST
Created attachment 385006 [details] Patch
youenn fablet
Comment 2 2019-12-06 07:48:29 PST
Created attachment 385012 [details] Patch
youenn fablet
Comment 3 2019-12-06 09:03:54 PST
Created attachment 385019 [details] Patch
Eric Carlson
Comment 4 2019-12-06 09:47:49 PST
Comment on attachment 385019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385019&action=review > Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp:404 > + if (m_imageTransferSession) { It is probably worth logging if m_imageTransferSession is NULL at this point.
Eric Carlson
Comment 5 2019-12-06 09:48:18 PST
Very nice!
youenn fablet
Comment 6 2019-12-08 08:08:43 PST
Created attachment 385122 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-12-08 11:10:10 PST
Comment on attachment 385122 [details] Patch for landing Clearing flags on attachment: 385122 Committed r253275: <https://trac.webkit.org/changeset/253275>
WebKit Commit Bot
Comment 8 2019-12-08 11:10:12 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-12-08 11:11:35 PST
<rdar://problem/57735210>
Jonathan Bedard
Comment 10 2019-12-09 09:02:28 PST
Pretty confident this caused a layout test regression on Mac: https://results.webkit.org/?suite=layout-tests&test=fast%2Fmediastream%2Fmediastreamtrack-video-clone.html&platform=mac
youenn fablet
Comment 11 2019-12-09 09:21:54 PST
See https://bugs.webkit.org/show_bug.cgi?id=205006
Note You need to log in before you can comment on or make changes to this bug.