| Summary: | Support different resolutions for video tracks captured from UIProcess | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, hta, jbedard, jer.noble, jlewis3, philipj, sergio, tommyw, tsavell, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2019-12-06 05:01:29 PST
Created attachment 385006 [details]
Patch
Created attachment 385012 [details]
Patch
Created attachment 385019 [details]
Patch
Comment on attachment 385019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385019&action=review > Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp:404 > + if (m_imageTransferSession) { It is probably worth logging if m_imageTransferSession is NULL at this point. Very nice! Created attachment 385122 [details]
Patch for landing
Comment on attachment 385122 [details] Patch for landing Clearing flags on attachment: 385122 Committed r253275: <https://trac.webkit.org/changeset/253275> All reviewed patches have been landed. Closing bug. Pretty confident this caused a layout test regression on Mac: https://results.webkit.org/?suite=layout-tests&test=fast%2Fmediastream%2Fmediastreamtrack-video-clone.html&platform=mac |