Bug 204908

Summary: Add ThreadMessageReceiver to IPC::Connection
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Sihui Liu
Reported 2019-12-05 13:29:54 PST
...
Attachments
Patch (7.67 KB, patch)
2019-12-05 13:35 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.89 KB, patch)
2019-12-05 15:08 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2019-12-05 13:35:25 PST
Created attachment 384939 [details] Patch
Brady Eidson
Comment 2 2019-12-05 14:15:55 PST
Comment on attachment 384939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384939&action=review It's weird to be adding dead code, but I happen to know it's in prep for https://bugs.webkit.org/show_bug.cgi?id=203690 To make sure everybody knows, please reference in the ChangeLog > Source/WebKit/Platform/IPC/Connection.h:341 > + Lock m_threadMessageReceiversMutex; It's a lock, not a mutex. Let's name it as such.
Chris Dumez
Comment 3 2019-12-05 14:22:24 PST
Comment on attachment 384939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384939&action=review > Source/WebKit/ChangeLog:7 > + Please add a change log!
Sihui Liu
Comment 4 2019-12-05 15:08:01 PST
Created attachment 384966 [details] Patch for landing
WebKit Commit Bot
Comment 5 2019-12-05 15:29:05 PST
Comment on attachment 384966 [details] Patch for landing Clearing flags on attachment: 384966 Committed r253177: <https://trac.webkit.org/changeset/253177>
WebKit Commit Bot
Comment 6 2019-12-05 15:29:06 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-12-05 15:30:35 PST
<rdar://problem/57679992>
Note You need to log in before you can comment on or make changes to this bug.