Bug 204902

Summary: Add CSS parser support for the highlight pseudoelement
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, megan_gardner, menard, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204924
Bug Depends on:    
Bug Blocks: 204903    
Attachments:
Description Flags
Patch koivisto: review+

Simon Fraser (smfr)
Reported 2019-12-05 11:12:27 PST
Add CSS parser support for the highlight pseudoelement
Attachments
Patch (5.23 KB, patch)
2019-12-05 11:13 PST, Simon Fraser (smfr) 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2019-12-05 11:13:39 PST
Created attachment 384924 [details] Patch
Simon Fraser (smfr)
Comment 2 2019-12-05 11:29:54 PST
https://trac.webkit.org/changeset/253158/webkit
Radar WebKit Bug Importer
Comment 3 2019-12-05 11:30:27 PST
<rdar://problem/57670974>
Darin Adler
Comment 4 2019-12-06 12:04:54 PST
Comment on attachment 384924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384924&action=review > Source/WebCore/rendering/style/RenderStyleConstants.h:85 > -enum class PseudoId : uint8_t { > +enum class PseudoId : uint16_t { What’s the rationale for this change?
Simon Fraser (smfr)
Comment 5 2019-12-06 13:45:01 PST
(In reply to Darin Adler from comment #4) > Comment on attachment 384924 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384924&action=review > > > Source/WebCore/rendering/style/RenderStyleConstants.h:85 > > -enum class PseudoId : uint8_t { > > +enum class PseudoId : uint16_t { > > What’s the rationale for this change? Compiler was telling me that uint8_t wasn't big enough at the: PublicPseudoIdMask = ((1 << FirstInternalPseudoId) - 1) & ~((1 << FirstPublicPseudoId) - 1) line, but maybe I need to fix that bitmasking instead.
Darin Adler
Comment 6 2019-12-06 13:51:44 PST
Comment on attachment 384924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384924&action=review >>> Source/WebCore/rendering/style/RenderStyleConstants.h:85 >>> +enum class PseudoId : uint16_t { >> >> What’s the rationale for this change? > > Compiler was telling me that uint8_t wasn't big enough at the: > PublicPseudoIdMask = ((1 << FirstInternalPseudoId) - 1) & ~((1 << FirstPublicPseudoId) - 1) > line, but maybe I need to fix that bitmasking instead. Looks to me like the issue is that PublicPseudoIdMask should not be a PseudoId value. It’s mask for use when these PseudoId values are used as bit numbers, not one of the PseudoId values. So we should move it out of the enum class.
Simon Fraser (smfr)
Comment 7 2019-12-06 15:24:01 PST
Yeah I'll do that.
Note You need to log in before you can comment on or make changes to this bug.