Bug 204858

Summary: Resource Load Statistics (experimental): Add fast mode for non-cookie website data deletion
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=204779
Attachments:
Description Flags
Patch
none
Patch for landing none

John Wilander
Reported 2019-12-04 13:45:35 PST
We need a significantly shorter timeout than 7 days for testing purposes.
Attachments
Patch (19.48 KB, patch)
2019-12-05 12:48 PST, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.46 KB, patch)
2019-12-05 15:56 PST, John Wilander 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-04 13:47:04 PST
<rdar://problem/57639851>
John Wilander
Comment 2 2019-12-05 12:48:14 PST
Created attachment 384936 [details] Patch
Alex Christensen
Comment 3 2019-12-05 15:02:24 PST
Comment on attachment 384936 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384936&action=review > Source/WebKit/Shared/WebPreferences.yaml:1822 > - defaultValue: false > + defaultValue: true Was this change intentional?
John Wilander
Comment 4 2019-12-05 15:04:14 PST
(In reply to Alex Christensen from comment #3) > Comment on attachment 384936 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384936&action=review > > > Source/WebKit/Shared/WebPreferences.yaml:1822 > > - defaultValue: false > > + defaultValue: true > > Was this change intentional? Yes, I mention it in the change log: "This change changes the default value of IsFirstPartyWebsiteDataRemovalEnabled to true." The reason is that the related patch landed with it off by default so that we could decide on a test setup before turning it on. This patch is the test setup.
John Wilander
Comment 5 2019-12-05 15:56:57 PST
Created attachment 384971 [details] Patch for landing
John Wilander
Comment 6 2019-12-05 15:57:27 PST
Thanks, Alex! I found a stray newline and deleted it.
WebKit Commit Bot
Comment 7 2019-12-05 16:26:16 PST
Comment on attachment 384971 [details] Patch for landing Clearing flags on attachment: 384971 Committed r253185: <https://trac.webkit.org/changeset/253185>
WebKit Commit Bot
Comment 8 2019-12-05 16:26:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.