Bug 204801

Summary: Add a runtime setting for media in the GPU process
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jer.noble, jonlee, justin_fan, sabouhallawa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Eric Carlson 2019-12-03 11:12:43 PST
Add a runtime setting for media in the GPU process
Comment 1 Radar WebKit Bug Importer 2019-12-03 11:13:03 PST
<rdar://problem/57596199>
Comment 2 Eric Carlson 2019-12-03 11:21:04 PST
Created attachment 384727 [details]
Patch
Comment 3 Jer Noble 2019-12-03 13:26:52 PST
Comment on attachment 384727 [details]
Patch

r=me with nit: could we rename the preference "outOfProcessMediaEnabled"?
Comment 4 Eric Carlson 2019-12-03 13:43:48 PST
Created attachment 384753 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-12-03 14:56:54 PST
Comment on attachment 384753 [details]
Patch for landing

Clearing flags on attachment: 384753

Committed r253063: <https://trac.webkit.org/changeset/253063>
Comment 6 WebKit Commit Bot 2019-12-03 14:56:55 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Tim Horton 2019-12-08 22:07:16 PST
Comment on attachment 384753 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=384753&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1832
> +OutOfProcessMediaEnabled:

I would have preferred something like "useGPUProcessForMedia". "Out of process" is so vague and is already true regardless, and "useGPUProcessForX" is easy to follow for the canvas, WebGL, and page-painting cases.

> Source/WebKit/Shared/WebPreferences.yaml:1838
> +    category: experimental

This should be an "internal" feature, not experimental. Definitely not ready for this to show up in STP