Summary: | WebProcessPool::terminateServiceWorkerProcess should be renamed terminateServiceWorkers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
youenn fablet
2019-12-03 05:49:26 PST
Created attachment 384709 [details]
Patch
Comment on attachment 384709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384709&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:-1733 > - auto protectedThis = makeRef(*this); Why drop this? Seems safer to protect ourselves as we iterate. Created attachment 384803 [details]
Patch for landing
(In reply to Chris Dumez from comment #2) > Comment on attachment 384709 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384709&action=review > > > Source/WebKit/UIProcess/WebProcessPool.cpp:-1733 > > - auto protectedThis = makeRef(*this); > > Why drop this? Seems safer to protect ourselves as we iterate. I kept it. Comment on attachment 384803 [details] Patch for landing Clearing flags on attachment: 384803 Committed r253103: <https://trac.webkit.org/changeset/253103> All reviewed patches have been landed. Closing bug. |