| Summary: | UserMediaCaptureManager should have independent capture factories | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2019-12-03 01:51:13 PST
Created attachment 384698 [details]
Patch
Comment on attachment 384698 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384698&action=review > Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:101 > + case CaptureDevice::DeviceType::Unknown: Nit: this should ASSERT_NOT_REACHED as the constructor does. Created attachment 384710 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 384710 [details]: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit.html bug 204800 (author: cdumez@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 384710 [details] Patch for landing Clearing flags on attachment: 384710 Committed r253055: <https://trac.webkit.org/changeset/253055> All reviewed patches have been landed. Closing bug. |