Summary: | [JSC] Put some destructible objects to IsoSubspace | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Yusuke Suzuki
2019-12-02 15:32:37 PST
Created attachment 384664 [details]
Patch
Comment on attachment 384664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384664&action=review r=me if tests pass. > Source/JavaScriptCore/runtime/DateInstance.h:89 > + JS_EXPORT_PRIVATE DateInstance(VM&, Structure*); > + void finishCreation(VM&); > + JS_EXPORT_PRIVATE void finishCreation(VM&, double); nit: can you put these above the 2 calculate functions above. I think we typically have the constructors come first. Comment on attachment 384664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384664&action=review >> Source/JavaScriptCore/runtime/DateInstance.h:89 >> + JS_EXPORT_PRIVATE void finishCreation(VM&, double); > > nit: can you put these above the 2 calculate functions above. I think we typically have the constructors come first. Sure, fixed. Created attachment 384668 [details]
Patch
Patch for landing
Committed r253019: <https://trac.webkit.org/changeset/253019> |