Bug 204771

Summary: [JSC] Put some destructible objects to IsoSubspace
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mark.lam: review+
Patch none

Yusuke Suzuki
Reported 2019-12-02 15:32:37 PST
[JSC] Put some destructible objects to IsoSubspace
Attachments
Patch (58.61 KB, patch)
2019-12-02 15:38 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Patch (58.69 KB, patch)
2019-12-02 16:10 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-12-02 15:38:36 PST
Created attachment 384664 [details] Patch
Mark Lam
Comment 2 2019-12-02 16:01:24 PST
Comment on attachment 384664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384664&action=review r=me if tests pass. > Source/JavaScriptCore/runtime/DateInstance.h:89 > + JS_EXPORT_PRIVATE DateInstance(VM&, Structure*); > + void finishCreation(VM&); > + JS_EXPORT_PRIVATE void finishCreation(VM&, double); nit: can you put these above the 2 calculate functions above. I think we typically have the constructors come first.
Yusuke Suzuki
Comment 3 2019-12-02 16:08:11 PST
Comment on attachment 384664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384664&action=review >> Source/JavaScriptCore/runtime/DateInstance.h:89 >> + JS_EXPORT_PRIVATE void finishCreation(VM&, double); > > nit: can you put these above the 2 calculate functions above. I think we typically have the constructors come first. Sure, fixed.
Yusuke Suzuki
Comment 4 2019-12-02 16:10:09 PST
Created attachment 384668 [details] Patch Patch for landing
Yusuke Suzuki
Comment 5 2019-12-02 17:47:41 PST
Committed r253019: <https://trac.webkit.org/changeset/253019>
Radar WebKit Bug Importer
Comment 6 2019-12-02 17:48:21 PST
<rdar://problem/57577848>
Note You need to log in before you can comment on or make changes to this bug.