Bug 204771

Summary: [JSC] Put some destructible objects to IsoSubspace
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mark.lam: review+
Patch none

Description Yusuke Suzuki 2019-12-02 15:32:37 PST
[JSC] Put some destructible objects to IsoSubspace
Comment 1 Yusuke Suzuki 2019-12-02 15:38:36 PST
Created attachment 384664 [details]
Patch
Comment 2 Mark Lam 2019-12-02 16:01:24 PST
Comment on attachment 384664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384664&action=review

r=me if tests pass.

> Source/JavaScriptCore/runtime/DateInstance.h:89
> +    JS_EXPORT_PRIVATE DateInstance(VM&, Structure*);
> +    void finishCreation(VM&);
> +    JS_EXPORT_PRIVATE void finishCreation(VM&, double);

nit: can you put these above the 2 calculate functions above.  I think we typically have the constructors come first.
Comment 3 Yusuke Suzuki 2019-12-02 16:08:11 PST
Comment on attachment 384664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384664&action=review

>> Source/JavaScriptCore/runtime/DateInstance.h:89
>> +    JS_EXPORT_PRIVATE void finishCreation(VM&, double);
> 
> nit: can you put these above the 2 calculate functions above.  I think we typically have the constructors come first.

Sure, fixed.
Comment 4 Yusuke Suzuki 2019-12-02 16:10:09 PST
Created attachment 384668 [details]
Patch

Patch for landing
Comment 5 Yusuke Suzuki 2019-12-02 17:47:41 PST
Committed r253019: <https://trac.webkit.org/changeset/253019>
Comment 6 Radar WebKit Bug Importer 2019-12-02 17:48:21 PST
<rdar://problem/57577848>