Bug 204727

Summary: [LFC][Render tree] Support LFC in LineLayoutTraversal
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, pdr, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
wip
none
patch
zalan: review+
patch none

Antti Koivisto
Reported 2019-12-01 07:54:53 PST
This allows render tree dumps, TextIterator etc. work with LFC inline layout.
Attachments
wip (45.99 KB, patch)
2019-12-01 07:58 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (47.96 KB, patch)
2019-12-01 12:21 PST, Antti Koivisto 		zalan: review+
DetailsFormatted DiffDiff
patch (48.25 KB, patch)
2019-12-02 00:07 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-12-01 07:58:44 PST
Created attachment 384572 [details] wip
Antti Koivisto
Comment 2 2019-12-01 12:21:36 PST
Created attachment 384578 [details] patch
zalan
Comment 3 2019-12-01 12:57:20 PST
Comment on attachment 384578 [details] patch Let's fix some of the naming in a separate patch. Will try to figure out something.
zalan
Comment 4 2019-12-01 20:55:37 PST
How about if we manage to move LineBox over to Display namespace the "results" could simply be something like Display::InlineContent
Antti Koivisto
Comment 5 2019-12-02 00:07:35 PST
Created attachment 384595 [details] patch
Antti Koivisto
Comment 6 2019-12-02 00:08:28 PST
(In reply to zalan from comment #4) > How about if we manage to move LineBox over to Display namespace the > "results" could simply be something like Display::InlineContent I made it Display::InlineContent. LineBox still needs moving.
WebKit Commit Bot
Comment 7 2019-12-02 01:29:06 PST
Comment on attachment 384595 [details] patch Clearing flags on attachment: 384595 Committed r252979: <https://trac.webkit.org/changeset/252979>
WebKit Commit Bot
Comment 8 2019-12-02 01:29:08 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-12-02 01:30:20 PST
<rdar://problem/57552905>
Note You need to log in before you can comment on or make changes to this bug.