Bug 204727

Summary: [LFC][Render tree] Support LFC in LineLayoutTraversal
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, pdr, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
wip
none
patch
zalan: review+
patch none

Description Antti Koivisto 2019-12-01 07:54:53 PST
This allows render tree dumps, TextIterator etc. work with LFC inline layout.
Comment 1 Antti Koivisto 2019-12-01 07:58:44 PST
Created attachment 384572 [details]
wip
Comment 2 Antti Koivisto 2019-12-01 12:21:36 PST
Created attachment 384578 [details]
patch
Comment 3 zalan 2019-12-01 12:57:20 PST
Comment on attachment 384578 [details]
patch

Let's fix some of the naming in a separate patch. Will try to figure out something.
Comment 4 zalan 2019-12-01 20:55:37 PST
How about if we manage to move LineBox over to Display namespace the "results" could simply be something like Display::InlineContent
Comment 5 Antti Koivisto 2019-12-02 00:07:35 PST
Created attachment 384595 [details]
patch
Comment 6 Antti Koivisto 2019-12-02 00:08:28 PST
(In reply to zalan from comment #4)
> How about if we manage to move LineBox over to Display namespace the
> "results" could simply be something like Display::InlineContent

I made it Display::InlineContent. LineBox still needs moving.
Comment 7 WebKit Commit Bot 2019-12-02 01:29:06 PST
Comment on attachment 384595 [details]
patch

Clearing flags on attachment: 384595

Committed r252979: <https://trac.webkit.org/changeset/252979>
Comment 8 WebKit Commit Bot 2019-12-02 01:29:08 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-12-02 01:30:20 PST
<rdar://problem/57552905>