Bug 204717

Summary: [Web Animations] Calling reverse() on an accelerated animation has no effect
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, dwilson1, esprehn+autocc, ews-watchlist, fred.wang, glenn, graouts, interalia.dev, kondapallykalyan, pdr, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
URL: https://jsfiddle.net/birtles/zcjgvfy2/22/
See Also: https://bugs.webkit.org/show_bug.cgi?id=204716
https://bugs.webkit.org/show_bug.cgi?id=211839
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2019-11-30 09:09:52 PST
If you go to https://jsfiddle.net/birtles/zcjgvfy2/22/ and press "counter-clockwise", the animation runs clockwise. I didn't check to be sure, but I believe the call to reverse() has no effect on the accelerated animation.
Attachments
Patch (31.29 KB, patch)
2020-05-13 06:49 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
interalia.dev
Comment 1 2020-04-28 01:55:41 PDT
This works properly in Firefox and Chrome. Still doesn't work in both latest Safari and TP.
Radar WebKit Bug Importer
Comment 2 2020-04-28 03:18:47 PDT
<rdar://problem/62503582>
Antoine Quint
Comment 3 2020-04-28 09:28:11 PDT
I think there are two issues here: 1. we don't reflect the animation's playback rate for accelerated animations 2. we don't reflect changes to timing properties while an accelerated animation is already running
Antoine Quint
Comment 4 2020-04-28 11:33:12 PDT
*** Bug 188841 has been marked as a duplicate of this bug. ***
Antoine Quint
Comment 5 2020-05-13 06:34:59 PDT
For now the approach will be to bail if we're trying to animate something with playbackRate != 1. We'll try to use CA animations for that case in bug 211839.
Antoine Quint
Comment 6 2020-05-13 06:49:12 PDT
Created attachment 399257 [details] Patch
EWS
Comment 7 2020-05-13 12:27:02 PDT
Committed r261637: <https://trac.webkit.org/changeset/261637> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399257 [details].
Note You need to log in before you can comment on or make changes to this bug.