| Summary: | Add mechanism for enabling internal and experimental features from run-webkit-test command line | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, glenn, graouts, jbedard, rniwa, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2019-11-29 07:56:07 PST
Created attachment 384511 [details]
patch
Comment on attachment 384511 [details] patch Clearing flags on attachment: 384511 Committed r252948: <https://trac.webkit.org/changeset/252948> All reviewed patches have been landed. Closing bug. Generally in favor of this, a few comments. 1st, this should probably apply to run-api-tests too. 2nd, we should consider what effect this will have when reporting results, if we intend to run queues with these flags (and I think we should be doing this, I know there is an intention to with a few features in the recent future). We should probably have this flag automatically set the configuration ‘flavor’ which is supposed to be the dumping ground for this sort of thing. > 2nd, we should consider what effect this will have when reporting results,
> if we intend to run queues with these flags (and I think we should be doing
> this, I know there is an intention to with a few features in the recent
> future). We should probably have this flag automatically set the
> configuration ‘flavor’ which is supposed to be the dumping ground for this
> sort of thing.
This was meant for engineers developing features, I didn't consider using it in infrastructure.
|