Bug 204702

Summary: Add mechanism for enabling internal and experimental features from run-webkit-test command line
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, graouts, jbedard, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2019-11-29 07:56:07 PST
Add a flag to run existing tests with LFC enabled.
Attachments
patch (8.01 KB, patch)
2019-11-29 09:10 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-11-29 09:10:46 PST
Created attachment 384511 [details] patch
WebKit Commit Bot
Comment 2 2019-11-29 10:54:24 PST
Comment on attachment 384511 [details] patch Clearing flags on attachment: 384511 Committed r252948: <https://trac.webkit.org/changeset/252948>
WebKit Commit Bot
Comment 3 2019-11-29 10:54:25 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-11-29 10:55:21 PST
<rdar://problem/57534243>
Jonathan Bedard
Comment 5 2019-12-02 09:01:37 PST
Generally in favor of this, a few comments. 1st, this should probably apply to run-api-tests too. 2nd, we should consider what effect this will have when reporting results, if we intend to run queues with these flags (and I think we should be doing this, I know there is an intention to with a few features in the recent future). We should probably have this flag automatically set the configuration ‘flavor’ which is supposed to be the dumping ground for this sort of thing.
Antti Koivisto
Comment 6 2019-12-02 13:23:13 PST
> 2nd, we should consider what effect this will have when reporting results, > if we intend to run queues with these flags (and I think we should be doing > this, I know there is an intention to with a few features in the recent > future). We should probably have this flag automatically set the > configuration ‘flavor’ which is supposed to be the dumping ground for this > sort of thing. This was meant for engineers developing features, I didn't consider using it in infrastructure.
Note You need to log in before you can comment on or make changes to this bug.