Bug 204698

Summary: Reimplement some PlatformCALayer methods using GraphicsContext instead of CGContextRef
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jonlee, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2019-11-29 03:48:54 PST
Reimplement some PlatformCALayer methods using GraphicsContext instead of CGContextRef
Attachments
Patch (26.48 KB, patch)
2019-11-29 03:49 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (27.34 KB, patch)
2019-11-29 13:57 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (27.37 KB, patch)
2019-11-29 14:03 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (28.25 KB, patch)
2019-11-29 16:57 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (28.52 KB, patch)
2019-11-30 16:24 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-11-29 03:49:21 PST
Created attachment 384494 [details] Patch
Tim Horton
Comment 2 2019-11-29 13:57:25 PST
Created attachment 384523 [details] Patch
Tim Horton
Comment 3 2019-11-29 14:03:54 PST
Created attachment 384525 [details] Patch
Tim Horton
Comment 4 2019-11-29 16:57:42 PST
Created attachment 384533 [details] Patch
Sam Weinig
Comment 5 2019-11-30 06:56:40 PST
Comment on attachment 384533 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384533&action=review > Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:1239 > +void PlatformCALayerCocoa::enumerateRectsBeingDrawn(GraphicsContext& context, void (^block)(CGRect)) Seems like block should probably take a FloatRect.
Tim Horton
Comment 6 2019-11-30 16:24:13 PST
Created attachment 384556 [details] Patch
WebKit Commit Bot
Comment 7 2019-11-30 17:06:57 PST
Comment on attachment 384556 [details] Patch Clearing flags on attachment: 384556 Committed r252962: <https://trac.webkit.org/changeset/252962>
WebKit Commit Bot
Comment 8 2019-11-30 17:06:59 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-11-30 17:07:16 PST
<rdar://problem/57541634>
Note You need to log in before you can comment on or make changes to this bug.