Bug 204695

Summary:

[AppleWin] WebKitQuartzCoreAdditions.dll isn't compiled since r248444

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

WebKit Misc.

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, annulen, bfulgham, commit-queue, don.olmstead, ews-watchlist, gyuyoung.kim, pvollan, ross.kirsling, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Fujii Hironori

Reported 2019-11-29 01:07:31 PST

[AppleWin] WebKitQuartzCoreAdditions.dll isn't compiled since r248444 Accelerated compositing doesn't work in AppleWin port because WebKitQuartzCoreAdditions.dll can't be found. r248444 (Bug 200539)

Attachments
Patch (1.37 KB, patch) 2019-11-29 01:17 PST, Fujii Hironori	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2019-11-29 01:17:40 PST

Created attachment 384487 [details] Patch

Per Arne Vollan

Comment 2 2019-11-30 16:31:23 PST

The test webanimations/accelerated-animation-removal-upon-transition-completion.html seems to be failing with this patch. Perhaps the test expectations should be updated?

Fujii Hironori

Comment 3 2019-11-30 17:24:58 PST

Yeah, this patch re-enable accelerated compositing for AppleWin. Will check and revise the patch. Thanks.

Fujii Hironori

Comment 4 2019-12-01 19:25:39 PST

BTW, do you have a plan to make 64bit WebKitSupportLibrary.zip and WebKitAuxiliaryLibrary.zip publicly available?

WebKit Commit Bot

Comment 5 2019-12-02 09:42:47 PST

Comment on attachment 384487 [details] Patch Clearing flags on attachment: 384487 Committed r252988: <https://trac.webkit.org/changeset/252988>

WebKit Commit Bot

Comment 6 2019-12-02 09:42:49 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2019-12-02 09:43:22 PST

<rdar://problem/57560633>

Note You need to log in before you can comment on or make changes to this bug.