| Summary: | Move soft update handling to network process | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | achristensen, cdumez, commit-queue, dbates, ews-watchlist, mkwst, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | 204641 | ||||||||||||||||
| Bug Blocks: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
youenn fablet
2019-11-28 05:39:59 PST
Created attachment 384450 [details]
Patch
Created attachment 384454 [details]
Patch
Created attachment 384459 [details]
Patch
Created attachment 384480 [details]
Patch
Created attachment 384697 [details]
Patch
Comment on attachment 384697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384697&action=review > Source/WebCore/workers/service/ServiceWorkerJobData.cpp:79 > + return scopeURL == job.scopeURL Some of these checks may need to be case insensitive. > Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h:55 > + ServiceWorkerSoftUpdateLoader(NetworkSession&, WebCore::ServiceWorkerJobData&&, bool shouldRefreshCache, WebCore::ResourceRequest&&, Handler&&); This should probably not be public, as clients are expected to call start(). (In reply to Chris Dumez from comment #6) > Comment on attachment 384697 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384697&action=review > > > Source/WebCore/workers/service/ServiceWorkerJobData.cpp:79 > > + return scopeURL == job.scopeURL > > Some of these checks may need to be case insensitive. Both script and scope are URLs. We do URL string comparison for job when matching registration. 'HTTP://example.org/I' will then have a different scope compared to 'HTTP://example.org/i'. This is consistent. I believe we should do the same for scripts as well. > > Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h:55 > > + ServiceWorkerSoftUpdateLoader(NetworkSession&, WebCore::ServiceWorkerJobData&&, bool shouldRefreshCache, WebCore::ResourceRequest&&, Handler&&); > > This should probably not be public, as clients are expected to call start(). OK Created attachment 384802 [details]
Patch for landing
Comment on attachment 384802 [details] Patch for landing Clearing flags on attachment: 384802 Committed r253102: <https://trac.webkit.org/changeset/253102> All reviewed patches have been landed. Closing bug. |